Repository navigation
Conversation
Profile DDAIs used override.<component>.disabled=true to avoid deploying a second Cluster Agent, CCR, or OTel Agent Gateway. That overloads a user-facing config field: code reading override.clusterAgent.disabled on a profile DDAI can't tell "the user has no Cluster Agent" from "another DDAI deploys it". Instead, the DDAI component reconciler skips cluster-wide components for DDAIs carrying the profile label, and profile DDAIs keep the user's component overrides as inherited from the DDA. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
3 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Gives profile DDAIs a dedicated signal for "don't deploy cluster-wide components from this DDAI", instead of overloading
override.<component>.disabled.setProfileSpecno longer forcesoverride.{clusterAgent,clusterChecksRunner,otelAgentGateway}.disabled: trueon user-created profile DDAIs. Thus keeps real values.Motivation
override.clusterAgent.disabledis a user-facing setting. On profile DDAIs it was alwaystrue, set by the operator, whether or not the user disabled the Cluster Agent. So code reading it on a DDAI can't tell "the user runs without a Cluster Agent" from "another DDAI deploys the Cluster Agent".This change makes it so the spec contains the true state of whether the component exists (even if it's managed by some external DDAI)
This should land before #3549 which is trying to actually take decisions if the cluster agent is disabled.
QA
Manual:
kubectl get ddai <profile-ddai> -o jsonpath='{.spec.override.clusterAgent}': should not containdisabled: true.Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel🤖 Generated with Claude Code