Repository navigation
Conversation
Update call sites broken by major-version bumps in renovate/major-go-dependencies: - mergo: github.com/imdario/mergo → dario.cat/mergo - gobwas/glob v1: Compile returns *glob.Pattern (not glob.Glob interface) - gopkg.in/yaml.v3: 4-space indent; update test expectations - helm v4: chartutil split across pkg/chart/common and pkg/chart/v2/util; Wait→WaitStrategy; Configuration.Init drops log arg; Run returns release.Releaser Environment: Datadog workspace Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
test/e2e uses replace directives pointing to the local root module. After the mergo module rename and helm/glob bumps in go.mod, the test/e2e module graph changed and its go.sum needed refreshing. Environment: Datadog workspace Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: Levan Machablishvili <levan.machablishvili@datadoghq.com>
Remove helm/v3, imdario/mergo, evanphx/json-patch (non-v5), hashicorp/errwrap, hashicorp/go-multierror, yaml.v2 entries. Add helm/v4 and its new transitive deps (wazero, extism, observe-sdk, fluxcd/cli-utils, ianlancetaylor/demangle). Environment: Datadog workspace Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes compilation and test failures introduced by the major-version bumps in #3490 (
renovate/major-go-dependencies).Changes
github.com/imdario/mergo→dario.cat/mergoingo.modand two import sitesCompilenow returns*glob.Patterninstead of theglob.Globinterface; update three call siteschartutilsplit:Values/ReadValues/YAML()→pkg/chart/common;LoadChartfile→pkg/chart/v2/utilWait bool→WaitStrategy kube.WaitStrategy(kube.StatusWatcherStrategy)Configuration.Initno longer takes a log funcRun/RunWithContextreturnrelease.Releaser(interface);UninstallReleaseResponse.ReleaselikewiseStatusUninstalledlives inhelm.sh/helm/v4/pkg/release/commonTesting
go build ./...— cleango test ./internal/controller/... ./cmd/yaml-mapper/... ./cmd/kubectl-datadog/...— all passgo vet— clean🤖 Generated with Claude Code