Fix bitrot - #714
Open
vlovich wants to merge 5 commits into
Open
Fix bitrot#714vlovich wants to merge 5 commits into
vlovich wants to merge 5 commits into
Conversation
vlovich
force-pushed
the
fix-bitrot
branch
2 times, most recently
from
September 3, 2026 21:45
813af3e to
ad2432d
Compare
Need to define LIBURING_INTERNAL because it's now static inline in the header by default but that doesn't work for a Rust build.
rand 0.10 carries breaking changes that break parts of the build. Since it's only used for test code, there's no serious impetus to fix 0.10 compat.
vlovich
force-pushed
the
fix-bitrot
branch
2 times, most recently
from
September 3, 2026 23:57
c6527e5 to
cd2303a
Compare
This comment has been minimized.
This comment has been minimized.
The reactor incorrectly assumed that a successful read of an empty file meant that the device support IOPOLL. That isn't actually the case as the kernel short-circuits that logic early into a success code. Instead, when we find the first operation on a device is opening an empty file, we create a sibling anonymous file and write some data for it that can be read back. This is a more reliable IOPOLL mechanism that won't get fooled into thinking a device supports IOPOLL when it doesn't.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Bump liburing to 2.15 to fix compilation issues.
Fix cargo clippy warnings printed by Rust 1.97
Deflake test_spin harder
Motivation
The project currently doesn't build.
Related issues
N/A
Additional Notes
N/A
Checklist
[N/A] I have added unit tests to the code I am submitting
[N/A] My unit tests cover both failure and success scenarios
[N/A] If applicable, I have discussed my architecture