[Fix-4564][admin] Rename physical resource files - #4569
Open
hutiefang76 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #4564.
Renaming a regular resource updated
dinky_resources, but the storage move was gated on finding child rows under the file ID. Regular files do not have children, so Local/HDFS/OSS rename was never called and Flink jobs could still resolve the old physical path.Brief change log
FileSystem.rename(...) == falseasRESOURCE_FILE_RENAME_FAILED, so the metadata transaction can roll back.The Data Studio route already queries the resource tree when it mounts with resources enabled, while its resource toolbar refreshes after successful operations. Returning from Registration Center therefore reloads the renamed resource without a separate frontend state path.
Verifying this change
HdfsResourceManagerTestandResourceServiceImplTestpassed.dinky-adminreactor: 160 tests, 0 failures, 0 errors, 30 skipped; all 48 modules succeeded.dinky-adminanddinky-client-base: passed.