Skip to content

fix: encode empty commitment cells as zero - #230

Merged
BernardLowe merged 1 commit into
mainfrom
codex/zero-empty-cell-scalar
Oct 24, 2026
Merged

BernardLowe merged 1 commit into
mainfrom
codex/zero-empty-cell-scalar

Conversation

@BernardLowe

Copy link
Copy Markdown
Contributor

Summary

  • What changed: KZG and IPA now map nil and zero-length Cells directly to scalar zero. Nonempty cells retain their existing SHA-256 mappings. Current conformance vectors and encoding specifications are updated in place, with regression coverage for empty and sparse vectors, boundary slots, prepared/single/batch openings, independent verifiers, replacements, and the optional KZG opening-computer path.
  • Why: Hashing empty Cells made semantically sparse fixed-width vectors cryptographically dense, preventing the commitment implementations from skipping zero scalars.

Testing

  • GOWORK=off go test -p=6 -parallel=6 ./...
  • GOWORK=off go vet -p=6 ./...
  • GOWORK=off go build -buildvcs=false -p=6 ./...
  • Targeted KZG/IPA tests, current conformance regeneration and validation, gofmt, and git diff --check.
  • Independent GPT-6 Astra (max) review: no actionable findings; five targeted tests independently rerun successfully.
  • Remote occupancy smoke against evaluator c4178a80ae1e50593c9ac48ff248380339ddfe62 on codex/benchmark-slot-occupancy, explicitly bound to Core cdfb12c6746d16a5ef197c3f2d2e8bfa0a380e9e through a separate Go workspace. All 66 KZG/IPA × 0–100% occupancy × commit/prove/verify cases passed with -benchtime=1x -count=1 -cpu=1, under a one-CPU scope and affinity limit. This is a correctness smoke, not a performance result.

Notes

  • This intentionally replaces the current pre-beta empty-cell encoding without a compatibility reader, profile/version bump, or release, as requested by the maintainer. Existing release tags and historical results remain unchanged.
  • Implemented by GPT-5.6 Luna (max), reviewed by GPT-6 Astra (max). Local full-module validation used six-CPU affinity, reduced process priority, and bounded Go concurrency. Actual GPU hardware execution was not exercised.
  • The evaluator dependency pin and integration Git links are unchanged. The remote source-validation workspace is /home/ubuntu/malt/worktrees/zero-empty-cell-occupancy/go.work; provenance and smoke output are retained beside it.

Map nil and zero-length cells directly to zero in KZG and IPA while retaining nonempty SHA-256 mappings. Update current conformance vectors and specifications in place, and cover empty, sparse, prepared, batch, replacement, and opening-computer paths.

Validation: bounded standalone Go tests, vet, build, targeted commitment tests, conformance regeneration, gofmt, and git diff --check.

Co-authored-by: Codex <codex@openai.com>
@BernardLowe
BernardLowe marked this pull request as ready for review October 24, 2026 07:38
Copilot AI balanced review requested due to automatic review settings October 24, 2026 07:38
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-24T07:38:13.960211Z cdfb12c Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

@BernardLowe
BernardLowe merged commit f7edf4e into main Oct 24, 2026
7 checks passed
@BernardLowe
BernardLowe deleted the codex/zero-empty-cell-scalar branch October 24, 2026 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants