Repository navigation
fix: encode empty commitment cells as zero - #230
Merged
Merged
Conversation
Map nil and zero-length cells directly to zero in KZG and IPA while retaining nonempty SHA-256 mappings. Update current conformance vectors and specifications in place, and cover empty, sparse, prepared, batch, replacement, and opening-computer paths. Validation: bounded standalone Go tests, vet, build, targeted commitment tests, conformance regeneration, gofmt, and git diff --check. Co-authored-by: Codex <codex@openai.com>
BernardLowe
marked this pull request as ready for review
October 24, 2026 07:38
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
GOWORK=off go test -p=6 -parallel=6 ./...GOWORK=off go vet -p=6 ./...GOWORK=off go build -buildvcs=false -p=6 ./...git diff --check.c4178a80ae1e50593c9ac48ff248380339ddfe62oncodex/benchmark-slot-occupancy, explicitly bound to Corecdfb12c6746d16a5ef197c3f2d2e8bfa0a380e9ethrough a separate Go workspace. All 66 KZG/IPA × 0–100% occupancy × commit/prove/verify cases passed with-benchtime=1x -count=1 -cpu=1, under a one-CPU scope and affinity limit. This is a correctness smoke, not a performance result.Notes
/home/ubuntu/malt/worktrees/zero-empty-cell-occupancy/go.work; provenance and smoke output are retained beside it.