Repository navigation
refactor: move experiment workers out of the node runtime - #73
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Experiment workers and replay orchestration were compiled inside the local storage node. Move them to
malt-evaluation/adapters/node, so the runtime supplies reusable authentication, storage and application capabilities while the evaluator owns workloads and accounting.tools/evaluationandinternal/evaluation; retain production UnixFS, Merkle DAG, trust and CAS behavior.nodeapi.CIDForBlockand reuse it from the runtime CAS implementation, so evaluator fixtures use the same CID calculation through a public API.Validated with independent runtime
go test,go vet, andgo build, plus the runtime checks in the selected Core/Gateway/runtime/evaluator workspace. Fresh independent reviews reported no actionable findings.Companion changes: malt-evaluation#62 and gateway#35. The evaluator pins this branch's immutable commit
333e94b03868db8687979020b49c7776837cb60a.