Repository navigation
feat(merkledag): batch directory updates per commit - #76
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiple file changes under the same directory currently persist an intermediate directory and every ancestor after each file. Add
Editor.BeginBatchfor basic UnixFS directories so callers can stage all bindings and write each surviving affected directory once, bottom-up, when committing the batch.File DAG objects retain their existing encoding and write path. Unchanged subtrees are reused, deleted directories are pruned without empty intermediate writes, and the Editor root advances only after every directory write succeeds. This is not a crash-atomic storage transaction; failed batches may leave immutable objects in CAS. Existing single-operation and HAMT APIs are unchanged.
Validation: the two-sibling regression observes exactly two directory writes (the final child directory and root); tests also cover initial snapshots, historical-root reads, CID equivalence with the existing editor, no-op batches, deletion, file/directory transitions, stale batches, cancellation and storage failure. Full runtime tests, vet, build and a fresh independent review passed.
DeWebProtocol/malt-evaluation#67 integrates one batch per initial snapshot and Git commit, with a new accounting contract for fresh Merkle replay results. Runtime GitHub CI passed the test/vet/build job and Linux, macOS and Windows builds.