fix(mobile): resolve simulator firebase crash and task repository pagination typecast - #134
Merged
Merged
Conversation
…ecast - Add safe fallback to FcmNotificationService when Firebase is not initialized - Update TaskRepository to safely extract items from paginated PagedResult responses - Prevent unhandled runtime exceptions during employee/team home initialization Relates to SDDC-80
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Jira / Task Reference
mobile📝 Summary of Changes
Fixes two critical runtime issues on mobile client startup:
[core/no-app] No Firebase App '[DEFAULT]' has been createdexception by adding safe initialization check (_resolveMessagingSafely) inFcmNotificationServicefor environments lacking iOS plist / development configurations.type '_Map<String, dynamic>' is not a subtype of type 'List<dynamic>' in type castby adding_extractListFromDatahelper inTaskRepositoryto support both flat list andPagedResult { items: [...] }backend response contracts.🏷️ Type of Change
🧪 Testing & Verification
Automated Tests
flutter test(All 20 tests passed)flutter analyze(No issues found)Manual Test Steps
Teamaccount; verifyResponse Team Portalloads active tasks and history without typecast SnackBar errors.Employeeaccount; verify rapid emergency grid functions seamlessly.📋 Pre-Merge Checklist
.envexclusions).In Review.