Skip to content

Build and deploy docs from CI and add a pass/fail check the org ruleset can require - #382

Merged
nbrownus merged 4 commits into
mainfrom
ci-status-gate
Sep 23, 2026
Merged

nbrownus merged 4 commits into
mainfrom
ci-status-gate

Conversation

@nbrownus

Copy link
Copy Markdown
Contributor

Nothing in CI built the site, the Cloudflare Pages integration did, so a PR that broke the build still went green. This adds a build job that runs on every PR, forks included, and a deploy job that publishes it with wrangler, main to production and every other branch to a preview. Fork PRs don't get secrets, so they build but skip the deploy. A pass/fail check job depends on every other job so the Required CI ruleset has one check to require.

Uses the org CLOUDFLARE_API_TOKEN secret. Once this is merged and main has deployed from CI, turn off automatic deployments on the docs-nebula Pages project so it stops building twice.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Deploying docs-nebula with  Cloudflare Pages  Cloudflare Pages

Latest commit: f545595
Status: ✅  Deploy successful!
Preview URL: https://0ea112c2.docs-nebula.pages.dev
Branch Preview URL: https://ci-status-gate.docs-nebula.pages.dev

View logs

@nbrownus
nbrownus requested a review from jasikpark September 23, 2026 15:08
@github-actions

github-actions Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for docs-nebula ready!

Name Link
🔨 Latest commit 8adcfff
🔍 Latest deploy log https://github.com/DefinedNet/nebula-docs/actions/runs/35892269774
😎 Deploy Preview Url https://46cc975d.docs-nebula.pages.dev
😎 Deploy Preview Alias https://ci-status-gate.docs-nebula.pages.dev

jasikpark
jasikpark previously approved these changes Sep 23, 2026

@jasikpark jasikpark left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

praise: The fork guard on deploy plus the separate build job means fork PRs still get a real build check, and a skipped deploy doesn't trip pass/fail check.

suggestion (non-blocking): The workflow-level concurrency group falls back to github.sha on push, so pushes to main never share a group and their production deploys can race (older finishing last wins). A job-level group on deploy would queue them in order:

concurrency:
  group: deploy-${{ github.ref }}
  cancel-in-progress: false

nitpick (non-blocking): upload-artifact / download-artifact are pinned at v4 while the rest of the file is on v6-era pins.

nitpick (non-blocking): If the build fails, the PR comment stays on "building..." until the next push (same as webclient), and the new jobs have no timeout-minutes.

question (non-blocking): Is docs-nebula's production branch set to main in Pages? Worth confirming the first CI deploy from main lands as production before turning off the git integration.

— Caleb + Cache

@jasikpark jasikpark left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for picking up the concurrency group and timeouts!

nitpick (non-blocking): The comment above GTAG_TRACKING_ID in docusaurus.config.ts still calls it a CF Workers environment variable. It comes from the Actions variable now.

— Caleb + Cache

@nbrownus
nbrownus merged commit 8cc74ea into main Sep 23, 2026
6 checks passed
@nbrownus
nbrownus deleted the ci-status-gate branch September 23, 2026 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants