restrict deployment to main branch - #7
Merged
Merged
Conversation
only the main branch should be able to deploy
Contributor
Author
|
@mmikhasenko please review |
szabo137
reviewed
Aug 28, 2026
| needs: build | ||
|
|
||
| # Deploy only after a push to the main branch. | ||
| if: ${{ github.event_name == 'push' && github.ref == 'refs/heads/main' }} |
There was a problem hiding this comment.
Seems this is also triggered if there is a direct push on main; not coming from a PR. I propose that we do not allow any direct push on main, maybe with the correct repo settings, or with a more constrained rule here. For instance:
if: >
github.event.action == 'closed' &&
github.event.pull_request.merged == true &&
github.event.pull_request.base.ref == 'main'
(not tested)
This would trigger the deployment only if there is a merged PR to main.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
only the main branch should be able to deploy