Repository navigation
fix(package): use host-provided TypeBox peer - #22
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Closes #21.
typeboxfrom runtime dependencies to a required wildcard peer, so Pi supplies its host module instead of installing an extension-local copy.Verification
npm ciandnpm run checkpass. Baseline: 134/134 tests; candidate: 137/137, no failures or skips. Build and typecheck pass.Additional checks:
--omit=peer: no physical TypeBox in the consumer, successfulget_state, andtypesafecommand registered. No host-dependency warning or extension error. No active Pi installation was modified.actionlint1.7.12 passes with ShellCheck disabled locally (ShellCheck is not installed); full workflow lint remains for CI.git diff --checkpasses. Scope: 7 files, 49 additions + 10 deletions (59 changed lines).Live testing is not applicable: no transport or response-validation behavior changes and no billable requests were sent.
Compatibility and release notes
No public API or package version change.
typeboxis intentionally not an optional peer: consumers outside Pi still need it. Package managers that do not automatically install peers must installtypeboxalongsidepi-typesafe, as documented in the README.Existing Pi peer ranges are unchanged. Other host versions, Node versions and macOS were not locally tested; the existing CI matrix covers the supported Node/platform combinations. Baseline and candidate npm installs both report one pre-existing high-severity transitive
brace-expansionadvisory; dependency security upgrades are outside this focused fix.