Skip to content

feat(renovate): enable Renovate's version presets for workflows, biome and Makefiles - #572

Open
DevSecNinja wants to merge 1 commit into
mainfrom
devsecninja-renovate-version-presets
Open

DevSecNinja wants to merge 1 commit into
mainfrom
devsecninja-renovate-version-presets

Conversation

@DevSecNinja

@DevSecNinja DevSecNinja commented Nov 17, 2026 •

Copy link
Copy Markdown
Owner

Description

The fleet inventory of untracked version pins (T127) found three pin shapes that Renovate's own first-party presets track, and the shared config doesn't enable them. This extends them in .renovate/default.json5, the preset every repository's renovate.json5 stub extends.

Changes

  • .renovate/default.json5:
    • customManagers:githubActionsVersions: # renovate: above an upper-case <NAME>_VERSION: key in workflows, workflow-templates and action.yml. Unblocks DevSecNinja/dotfiles ci.yaml MISE_VERSION: "2026.5.15" (the rest of the fleet is on 2026.11.x).
    • customManagers:biomeVersions: the `` version in biome.json(c) (DevSecNinja/hadiscover: 2.4.10, npm `@biomejs/biome`).
    • customManagers:makefileVersions: # renovate: above <NAME>_VERSION ?= in Makefiles (DevSecNinja/config-sidecar's GOLANGCI_LINT_VERSION once it's annotated; that repo PR is handled separately).
  • New tests/renovate-version-presets.sh in mise run test. It checks that the three presets are extended. It checks that githubActionsVersions and the central workflow manager never extract the same line: the preset takes upper-case _VERSION: keys and ours takes lower-case …version: keys (including this repo's apm_cli_version), using a copy of the preset's regex from Renovate's source. It also checks that no central custom manager targets biome.json or Makefiles.
  • docs/architecture.md: a paragraph in "Version annotations".

Why not widen the central workflow manager instead: that duplicates the preset. With both enabled, lower-case keys go to the central manager and upper-case keys to the preset, with no overlap. This repository's own renovate.json5 doesn't extend default.json5 and has no upper-case keys, so it is unchanged.

The soak, batch, automerge and labels apply as before: the presets only add extraction, and the existing github-releases, npm and other datasource rules decide what happens to the updates. Each preset is a no-op in repositories without the files. If a repo has @biomejs/biome in package.json too, both deps share the dependency name, so they update together.

Closes #571

Checklist

  • Linting passes locally (mise exec -- lefthook run pre-commit)
  • Commit messages follow Conventional Commits
  • Documentation updated (if applicable)

Validation (Windows/Git Bash):

  • bash ./tests/renovate-version-presets.sh: passed. Mutation check: without the default.json5 change it fails.
  • config-sync-renovate-stub.sh, renovate-batching-contract.sh, renovate-pin-no-soak.sh, renovate-branch-pin-digests.sh and renovate-dprint-plugins.sh: passed.
  • Renovate JSON schema validation of default.json5: OK. renovate-config-validator was not run (npm registry blocked here).
  • shellcheck, shfmt -d -i 4 and dprint check: clean. The full mise run test runs in CI.
  • Independent of feat(renovate): track shell-script version annotations and CRLF files #570 (shell manager and CRLF). The CRLF case of the central workflow manager is tested there.

Summary by CodeRabbit

  • Chores
    • Updated automated version tracking for GitHub Actions, Biome, and Makefiles.
  • Documentation
    • Documented which files are covered by the version tracking.
  • Tests
    • Added checks to verify version tracking rules and detect configuration issues.

…e and Makefiles

Extend customManagers:githubActionsVersions, biomeVersions and
makefileVersions in the default preset. They track upper-case
<NAME>_VERSION: workflow keys, the biome.json $schema version and
annotated Makefile <NAME>_VERSION ?= variables, and only act on repos with
those files. A test checks that githubActionsVersions and the central
workflow manager never extract the same line.

Closes #571

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@DevSecNinja
DevSecNinja requested a balanced review from Copilot November 17, 2026 16:53
@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The shared Renovate configuration now extends GitHub Actions, Biome, and Makefile version presets. Documentation describes their matching scope, and a contract test checks configuration and sample matches.

Changes: Renovate version presets

Layer / File(s) Summary
Enable and document version presets
.renovate/default.json5, docs/architecture.md
The default configuration extends the GitHub Actions, Biome, and Makefile version presets. The architecture documentation describes their target annotations and files.
Check preset matching and wire test
tests/renovate-version-presets.sh, .mise.toml
The contract test checks that the presets are extended, verifies workflow-manager uniqueness and sample matching, and reports failures. The test task runs this test.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Possibly related issues

  • DevSecNinja/.github issue 569: This change adds the githubActionsVersions preset and checks that it does not overlap with the central workflow manager. The issue’s shell-script annotation and CRLF matching objectives are not covered.
Merge Risk: Minimal · up to 47f3b

This change enables Renovate to track version pins in workflows, Biome schema URLs, and Makefiles for repositories that have matching files. No concrete merge-blocking risk was found. CI should confirm the full test run.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title states the main change: enabling Renovate's version presets (githubActionsVersions, biomeVersions, makefileVersions) in .renovate/default.json5 for workflows, Biome, and Makefiles. The raw s…
Linked Issues check Passed Issue #571 requires three coding outcomes. (1) Extend customManagers:githubActionsVersions, customManagers:biomeVersions and customManagers:makefileVersions in .renovate/default.json5. The head file e…
Out of Scope Changes check Passed All changes support issue #571. The default.json5 change adds the three presets. tests/renovate-version-presets.sh is the requested test. The .mise.toml change adds the new test to the mise run test t…
Full details: Title check

Explanation

The title states the main change: enabling Renovate's version presets (githubActionsVersions, biomeVersions, makefileVersions) in .renovate/default.json5 for workflows, Biome, and Makefiles. The raw summary, objectives, and linked issue #571 all describe this same change, and the added test and docs support it. The title is specific and matches the changeset.

Full details: Linked Issues check

Explanation

Issue #571 requires three coding outcomes. (1) Extend customManagers:githubActionsVersions, customManagers:biomeVersions and customManagers:makefileVersions in .renovate/default.json5. The head file extends all three, with comments naming the target file patterns. (2) Add a test that the presets are extended. tests/renovate-version-presets.sh checks each preset name in the extends array of default.json5. (3) Add a test that githubActionsVersions and the central workflow manager never extract the same line. The test runs a copy of the preset regex and the central matchStrings against sample upper-case _VERSION: keys, lower-case version: keys, and apm_cli_version, using LF and CRLF for the preset case. It asserts that exactly one manager matches each sample. The soak, batch and automerge rules are unchanged, which matches the issue's scope. The base revision of default.json5 could not be read, so the claim that the three presets were absent before this PR relies on the PR description and diff summary. This does not affect the verdict, because the head state meets the requirements.

Full details: Out of Scope Changes check

Explanation

All changes support issue #571. The default.json5 change adds the three presets. tests/renovate-version-presets.sh is the requested test. The .mise.toml change adds the new test to the mise run test task, which is needed to run it in CI. The docs/architecture.md paragraph documents the new presets under Version annotations. The test also checks that the central workflow manager does not target biome.json or Makefiles. This is a supporting check for the overlap requirement, not unrelated work. No change was found that lacks a connection to the issue.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2c2788b1-c638-4855-99cc-45a81335e7a4
Commits

Reviewing files that changed from the base of the PR and between b6c5949 and 47f3b6a.

Files selected for processing: 4

  • .mise.toml
  • .renovate/default.json5
  • docs/architecture.md
  • tests/renovate-version-presets.sh

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified for the Renovate preset additions and supporting changes.

No open issues 🎉

What changed in this PR

Enables three first-party Renovate presets in the shared fleet configuration to track previously uncovered version pins, addressing #571 without widening the central workflow manager.

Changes:

  • Adds presets for annotated workflow versions, Biome schema versions, and Makefile versions.
  • Adds a contract test for preset inclusion and manager non-overlap, registered in mise run test.
  • Documents the newly supported pin formats.
File Description
tests/​renovate-version-presets.sh Checks preset inclusion, workflow extraction ownership, and file-target overlap.
docs/​architecture.md Documents the three first-party presets and supported pin formats.
.renovate/​default.json5 Enables the workflow, Biome, and Makefile version presets.
.mise.toml Registers the new contract test in the test task.

Review effort: Balanced

@DevSecNinja

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@DevSecNinja

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(renovate): enable Renovate's githubActionsVersions, biomeVersions and makefileVersions presets

2 participants