Repository navigation
feat(renovate): enable Renovate's version presets for workflows, biome and Makefiles - #572
DevSecNinja wants to merge 1 commit into
Conversation
…e and Makefiles Extend customManagers:githubActionsVersions, biomeVersions and makefileVersions in the default preset. They track upper-case <NAME>_VERSION: workflow keys, the biome.json $schema version and annotated Makefile <NAME>_VERSION ?= variables, and only act on repos with those files. A test checks that githubActionsVersions and the central workflow manager never extract the same line. Closes #571 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the Renovate preset additions and supporting changes.
No open issues 🎉
What changed in this PR
Enables three first-party Renovate presets in the shared fleet configuration to track previously uncovered version pins, addressing #571 without widening the central workflow manager.
Changes:
- Adds presets for annotated workflow versions, Biome schema versions, and Makefile versions.
- Adds a contract test for preset inclusion and manager non-overlap, registered in
mise run test. - Documents the newly supported pin formats.
| File | Description |
|---|---|
tests/renovate-version-presets.sh |
Checks preset inclusion, workflow extraction ownership, and file-target overlap. |
docs/architecture.md |
Documents the three first-party presets and supported pin formats. |
.renovate/default.json5 |
Enables the workflow, Biome, and Makefile version presets. |
.mise.toml |
Registers the new contract test in the test task. |
Review effort: Balanced
|
@coderabbitai review |
Action not completed
|
|
@coderabbitai review |
Action performed
|
Description
The fleet inventory of untracked version pins (T127) found three pin shapes that Renovate's own first-party presets track, and the shared config doesn't enable them. This extends them in
.renovate/default.json5, the preset every repository'srenovate.json5stub extends.Changes
.renovate/default.json5:customManagers:githubActionsVersions:# renovate:above an upper-case<NAME>_VERSION:key in workflows, workflow-templates andaction.yml. Unblocks DevSecNinja/dotfilesci.yamlMISE_VERSION: "2026.5.15"(the rest of the fleet is on 2026.11.x).customManagers:biomeVersions: the `` version inbiome.json(c)(DevSecNinja/hadiscover: 2.4.10, npm `@biomejs/biome`).customManagers:makefileVersions:# renovate:above<NAME>_VERSION ?=in Makefiles (DevSecNinja/config-sidecar'sGOLANGCI_LINT_VERSIONonce it's annotated; that repo PR is handled separately).tests/renovate-version-presets.shinmise run test. It checks that the three presets are extended. It checks thatgithubActionsVersionsand the central workflow manager never extract the same line: the preset takes upper-case_VERSION:keys and ours takes lower-case…version:keys (including this repo'sapm_cli_version), using a copy of the preset's regex from Renovate's source. It also checks that no central custom manager targetsbiome.jsonor Makefiles.docs/architecture.md: a paragraph in "Version annotations".Why not widen the central workflow manager instead: that duplicates the preset. With both enabled, lower-case keys go to the central manager and upper-case keys to the preset, with no overlap. This repository's own
renovate.json5doesn't extenddefault.json5and has no upper-case keys, so it is unchanged.The soak, batch, automerge and labels apply as before: the presets only add extraction, and the existing
github-releases,npmand other datasource rules decide what happens to the updates. Each preset is a no-op in repositories without the files. If a repo has@biomejs/biomeinpackage.jsontoo, both deps share the dependency name, so they update together.Closes #571
Checklist
mise exec -- lefthook run pre-commit)Validation (Windows/Git Bash):
bash ./tests/renovate-version-presets.sh: passed. Mutation check: without thedefault.json5change it fails.config-sync-renovate-stub.sh,renovate-batching-contract.sh,renovate-pin-no-soak.sh,renovate-branch-pin-digests.shandrenovate-dprint-plugins.sh: passed.default.json5: OK.renovate-config-validatorwas not run (npm registry blocked here).shellcheck,shfmt -d -i 4anddprint check: clean. The fullmise run testruns in CI.Summary by CodeRabbit