Skip to content

chore(ci): bump the reusable lint workflow to v3.7.1 and pin yamllint - #256

Merged
DevSecNinja merged 1 commit into
devsecninja-hook-git-env-isolationfrom
devsecninja-lint-workflow-v3
Nov 16, 2026
Merged

DevSecNinja merged 1 commit into
devsecninja-hook-git-env-isolationfrom
devsecninja-lint-workflow-v3

Conversation

@DevSecNinja

Copy link
Copy Markdown
Owner

Summary

Bumps only the reusable lint workflow caller (.github/workflows/lint.yml) from DevSecNinja/.github v1.9.0 (27fd667) to v3.7.1 (e28a49a14d4530962b165e0d35a8a331b2b42f23, the commit the v3.7.1 tag points to), and pins pipx:yamllint 1.38.0 in .mise.toml.

Why: v1.9.0's yamllint and checkov jobs install only uv pipx:<tool>. Once #247 makes Python a configured mise tool (#246), mise requires that Python before any pipx: tool, and both jobs fail. Since v2.1.0, the shared workflow runs the caller's full mise install, which installs the configured Python first (DevSecNinja/.github#502). It also requires every lint tool to be pinned in the caller's mise config, which yamllint wasn't. Renovate's mise manager tracks the new pin like the other tools.

v1.9.0 → v3.7.1 interface check: no inputs were removed or changed. Two inputs were added, and their defaults keep current behavior:

  • lint-job-mode (auto): one job per linter for public repos like this one, so the lint / <tool> check names stay the same.
  • upload-sarif (true): checkov, trivy and zizmor still upload to code scanning.

The go job still skips without go.mod. Every job now runs a full mise install. All other lint tools were already pinned in .mise.toml.

The release-please, config-sync, apm-materialize and skillspector callers are left alone; they're part of the caller migration (#130).

Stacked: #252 (hook fix) ← this PR ← #247 (mise Python).

Validation (native Windows ARM64, fresh testing context)

  • actionlint, yamlfmt and dprint pass. gh api …/git/refs/tags/v3.7.1 resolves to e28a49a.
  • mise parses pipx:yamllint 1.38.0, and yamllint runs on lint.yml.
  • lefthook run pre-commit --all-files passes.
  • The commit is signed (1Password SSH).

Closes #255

@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 29 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8278f7ec-a9cd-416f-89bf-14fdd27257a6
Commits

Reviewing files that changed from the base of the PR and between 53c9e4e and 124c0a2.

Files selected for processing: 2

  • .github/workflows/lint.yml
  • .mise.toml
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified for the lint workflow update and yamllint version pin.

No open issues 🎉

What changed in this PR

Updates the shared lint workflow to prepare CI for the mise-managed Python change in #247, while leaving other workflow migrations to #130.

Changes:

  • Bumps the lint workflow from v1.9.0 to SHA-pinned v3.7.1, which installs the caller’s full mise tool configuration.
  • Pins pipx:yamllint to 1.38.0 to meet the updated workflow’s tool requirements.
File Description
.mise.toml Adds the Renovate-managed yamllint 1.38.0 pin.
.github/​workflows/​lint.yml Updates the reusable lint workflow reference to v3.7.1.

Review effort: Balanced

@DevSecNinja
DevSecNinja force-pushed the devsecninja-lint-workflow-v3 branch 2 times, most recently from da7abac to 08bc44c Compare November 16, 2026 11:36
v1.9.0 installs only `uv pipx:<tool>` in the yamllint and checkov jobs,
which fails once the repo configures a mise Python (#246): mise needs that
Python before any pipx tool. Since v2.1.0 the shared workflow runs the
caller's full mise install, which installs it first, and requires every
lint tool to be pinned in the caller's mise config, so pin yamllint
(Renovate-managed). No inputs were removed or changed; v3.7.1 adds
`lint-job-mode` (auto: per-linter jobs for this public repo, so the check
names stay) and `upload-sarif` (default true, as before).

Closes #255

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@DevSecNinja
DevSecNinja force-pushed the devsecninja-lint-workflow-v3 branch from 08bc44c to 124c0a2 Compare November 16, 2026 12:07
@DevSecNinja
DevSecNinja merged commit b0a434b into main Nov 16, 2026
20 checks passed
@DevSecNinja
DevSecNinja deleted the devsecninja-lint-workflow-v3 branch November 16, 2026 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(ci): bump the reusable lint workflow to v3.7.1 and pin yamllint

2 participants