Repository navigation
chore(ci): bump the reusable lint workflow to v3.7.1 and pin yamllint - #256
Merged
DevSecNinja merged 1 commit intoNov 16, 2026
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 29 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the lint workflow update and yamllint version pin.
No open issues 🎉
What changed in this PR
Updates the shared lint workflow to prepare CI for the mise-managed Python change in #247, while leaving other workflow migrations to #130.
Changes:
- Bumps the lint workflow from v1.9.0 to SHA-pinned v3.7.1, which installs the caller’s full mise tool configuration.
- Pins
pipx:yamllintto 1.38.0 to meet the updated workflow’s tool requirements.
| File | Description |
|---|---|
.mise.toml |
Adds the Renovate-managed yamllint 1.38.0 pin. |
.github/workflows/lint.yml |
Updates the reusable lint workflow reference to v3.7.1. |
Review effort: Balanced
DevSecNinja
force-pushed
the
devsecninja-lint-workflow-v3
branch
2 times, most recently
from
November 16, 2026 11:36
da7abac to
08bc44c
Compare
v1.9.0 installs only `uv pipx:<tool>` in the yamllint and checkov jobs, which fails once the repo configures a mise Python (#246): mise needs that Python before any pipx tool. Since v2.1.0 the shared workflow runs the caller's full mise install, which installs it first, and requires every lint tool to be pinned in the caller's mise config, so pin yamllint (Renovate-managed). No inputs were removed or changed; v3.7.1 adds `lint-job-mode` (auto: per-linter jobs for this public repo, so the check names stay) and `upload-sarif` (default true, as before). Closes #255 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
DevSecNinja
force-pushed
the
devsecninja-lint-workflow-v3
branch
from
November 16, 2026 12:07
08bc44c to
124c0a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps only the reusable lint workflow caller (
.github/workflows/lint.yml) from DevSecNinja/.github v1.9.0 (27fd667) to v3.7.1 (e28a49a14d4530962b165e0d35a8a331b2b42f23, the commit thev3.7.1tag points to), and pinspipx:yamllint1.38.0 in.mise.toml.Why: v1.9.0's yamllint and checkov jobs install only
uv pipx:<tool>. Once #247 makes Python a configured mise tool (#246), mise requires that Python before anypipx:tool, and both jobs fail. Since v2.1.0, the shared workflow runs the caller's fullmise install, which installs the configured Python first (DevSecNinja/.github#502). It also requires every lint tool to be pinned in the caller's mise config, whichyamllintwasn't. Renovate's mise manager tracks the new pin like the other tools.v1.9.0 → v3.7.1 interface check: no inputs were removed or changed. Two inputs were added, and their defaults keep current behavior:
lint-job-mode(auto): one job per linter for public repos like this one, so thelint / <tool>check names stay the same.upload-sarif(true): checkov, trivy and zizmor still upload to code scanning.The
gojob still skips withoutgo.mod. Every job now runs a fullmise install. All other lint tools were already pinned in.mise.toml.The release-please, config-sync, apm-materialize and skillspector callers are left alone; they're part of the caller migration (#130).
Stacked: #252 (hook fix) ← this PR ← #247 (mise Python).
Validation (native Windows ARM64, fresh testing context)
gh api …/git/refs/tags/v3.7.1resolves toe28a49a.pipx:yamllint1.38.0, and yamllint runs onlint.yml.lefthook run pre-commit --all-filespasses.Closes #255