Skip to content

ci: pin .github callers to v4.2.0 - #454

Merged
DevSecNinja merged 1 commit into
mainfrom
steward/config-sync-v4-2-0
Nov 17, 2026
Merged

DevSecNinja merged 1 commit into
mainfrom
steward/config-sync-v4-2-0

Conversation

@DevSecNinja

@DevSecNinja DevSecNinja commented Nov 16, 2026 •

Copy link
Copy Markdown
Owner

Closes #453

Changes

  • .github/workflows/config-sync.yml: pin to v4.2.0 (5eceec313066eefaa0fe9e3dbf4f9a5a49b55ebd).

release-please.yml is unchanged since v3.4.0. config-sync.yml keeps the same inputs, secrets and permissions. It now checks out with persist-credentials: false, commits through open-pr v4.1.0 (commit-method: api, signed by GitHub) and treats renovate.json5 as create-only. The sync warns while renovate.json5 doesn't extend github>DevSecNinja/.github//.renovate/default.json5; converting it is DevSecNinja/.github#513.

Post-merge check

  • Release Please on the merge push is green (when the repo has a release-please caller).
  • Dispatch Config Sync: green, and the sync PR commit is Verified and doesn't touch renovate.json5.

Part of DevSecNinja/repo-steward#73 (batch 4, owner-approved). Opened by repo-steward through the GitHub API; the commit is signed by GitHub (createCommitOnBranch).

Summary by CodeRabbit

  • Chores
    • Updated the configuration synchronization workflow to a newer version. No direct changes to the end-user experience are included in this update.

Part of DevSecNinja/repo-steward#73 (batch 4).

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 16, 2026 19:29
@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The config-sync workflow now calls the reusable workflow at revision 5eceec313066eefaa0fe9e3dbf4f9a5a49b55ebd (v4.2.0), replacing the v3.6.0 revision.

Changes: Config-sync workflow

Layer / File(s) Summary
Update reusable workflow reference
.github/workflows/config-sync.yml
The sync job now references the reusable workflow at v4.2.0 instead of v3.6.0.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other · Severity of issue fixed: Medium

Possibly related PRs

  • DevSecNinja/hadiscover#449: This PR also updates the config-sync workflow pin and establishes the secret-passing contract retained here.
Merge Risk: Minimal · up to 22d91

This updates the config-sync workflow to the shared v4.2.0 release, which makes sync commits GitHub-signed and stops it overwriting renovate.json5. No concrete problems were found, and reverting the pin is a simple rollback. Confirm after merge that a Config Sync dispatch produces a Verified commit.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "ci: pin .github callers to v4.2.0" matches the main change. The only file change pins the config-sync workflow reference from v3.6.0 to v4.2.0 in .github/workflows/config-sync.yml, and the …
Linked Issues check Passed Issue #453 asks to pin the .github callers to v4.2.0. At the reviewed head, .github/workflows/config-sync.yml calls DevSecNinja/.github@5eceec3…
Out of Scope Changes check Passed The PR changes one line in .github/workflows/config-sync.yml: the pinned revision of the reusable config-sync workflow. The change matches the objective of #453. The change adds no unrelated files or …
Full details: Title check

Explanation

The title "ci: pin .github callers to v4.2.0" matches the main change. The only file change pins the config-sync workflow reference from v3.6.0 to v4.2.0 in .github/workflows/config-sync.yml, and the linked issue #453 asks for this same pin. The title is short, specific, and uses a conventional commit prefix. It does not mention the renovate.json5 create-only behavior, but that is a detail of the pinned version rather than the primary change.

Full details: Linked Issues check

Explanation

Issue #453 asks to pin the .github callers to v4.2.0. At the reviewed head, .github/workflows/config-sync.yml calls DevSecNinja/.github@5eceec3 # v4.2.0. The inputs and secrets block keeps the same secret mapping. This meets the coding requirement. The two behaviors named in the issue (create-only renovate.json5 from v4.0.0 and GitHub-signed sync commits from v4.2.0) come from the pinned upstream reusable workflow. The upstream source is not in this repository, so this assessment does not independently verify those behaviors. No separate code change is required here for them. The repository has no release-please.yml workflow file in the reviewed tree. The PR description states that release-please.yml is unchanged, so no further pin is needed for it. Post-merge checks in the PR description are non-coding and do not affect this result.

Full details: Out of Scope Changes check

Explanation

The PR changes one line in .github/workflows/config-sync.yml: the pinned revision of the reusable config-sync workflow. The change matches the objective of #453. The change adds no unrelated files or logic. The raw summary reports a diff of +1/-1 and no declaration changes. The reviewed tree lists no other changed paths tied to this PR. The diff read tool was unavailable, so the one-line size rests on the supplied summary and the head file content.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 638837ca-4ec4-4f61-9d73-30a1fae4541a
Commits

Reviewing files that changed from the base of the PR and between b0498a9 and 22d916d.

Files selected for processing: 1

  • .github/workflows/config-sync.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@github-actions

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails
actions/DevSecNinja/.github/.github/workflows/config-sync.yml 5eceec313066eefaa0fe9e3dbf4f9a5a49b55ebd UnknownUnknown

Scanned Files

  • .github/workflows/config-sync.yml

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the update to Config Sync v4.2.0.

No open issues 🎉

What changed in this PR

Updates hadiscover’s Config Sync caller to DevSecNinja/.github v4.2.0 to adopt GitHub-signed sync commits and preserve existing renovate.json5 files, as requested in #453.

Changes:

  • Replaces the v3.6.0 pin with the full v4.2.0 commit SHA.
  • Keeps caller inputs, secrets, and permissions unchanged.

Validation was limited to the supplied diff. Tests, builds, and workflow dispatches were not run.

File Description
.github/​workflows/​config-sync.yml Pins the reusable Config Sync workflow to v4.2.0 (5eceec313066eefaa0fe9e3dbf4f9a5a49b55ebd).

Review effort: Balanced

@DevSecNinja
DevSecNinja merged commit 302885e into main Nov 17, 2026
27 checks passed
@DevSecNinja
DevSecNinja deleted the steward/config-sync-v4-2-0 branch November 17, 2026 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: pin .github callers to v4.2.0 (signed config-sync, create-only renovate.json5)

2 participants