Skip to content

chore(renovate): track pre-commit hook revisions - #461

Open
DevSecNinja wants to merge 1 commit into
mainfrom
steward/renovate-pre-commit
Open

DevSecNinja wants to merge 1 commit into
mainfrom
steward/renovate-pre-commit

Conversation

@DevSecNinja

@DevSecNinja DevSecNinja commented Nov 17, 2026 •

Copy link
Copy Markdown
Owner

Description

Renovate's pre-commit manager is off by default, so the hook revisions in .pre-commit-config.yaml were never updated.

Changes

  • renovate.json5: enable the pre-commit manager for the 13 rev: pins.
  • renovate.json5: a custom manager for npm packages in additional_dependencies (the built-in manager only updates Python ones), which covers @biomejs/biome@2.3.10.

Expect a first batch of hook updates after merge; non-major ones land in the weekly group, major ones in their own PRs.

Closes #460

Checklist

  • Linting passes locally (mise exec -- lefthook run pre-commit)
  • Commit messages follow Conventional Commits
  • Documentation updated (if applicable)

Validation (static and API-only; the repo was not cloned and nothing was executed in it): changed JSON5
files parse, and every new or affected Renovate regex was run (in Python, with RE2/JS named groups
translated) against the files on main. Each matches exactly the lines listed above.
renovate-config-validator was not run (the npm registry is blocked on the authoring machine). Renovate
validates the config on its next run and reports problems on the Dependency Dashboard.

Summary by CodeRabbit

  • Chores
    • Renovate now checks npm dependencies listed in pre-commit configuration files and can propose updates for them.

Copilot AI balanced review requested due to automatic review settings November 17, 2026 16:55
@github-actions

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

Renovate now enables its pre-commit manager and includes a regex custom manager that identifies npm dependencies in .pre-commit-config.yaml files.

Changes: Pre-commit dependency updates

Layer / File(s) Summary
Configure pre-commit dependency matching
renovate.json5
Renovate enables its pre-commit manager and matches quoted package and version entries in additional_dependencies lists. The custom manager uses the npm datasource.

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Suggested labels: configuration

Merge Risk: Minimal · up to f52dd

This change makes Renovate track pre-commit hook revisions and the Biome npm dependency in the pre-commit config. It affects only dependency-update automation, so there is no production impact. No merge-blocking issue was found. Running renovate-config-validator after merge, or before it if convenient, would add confidence.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "chore(renovate): track pre-commit hook revisions" matches the main change. The PR enables Renovate's pre-commit manager so it tracks the 13 rev pins in .pre-commit-config.yaml. It also adds…
Linked Issues check Passed Issue #460 requires Renovate to track the 13 rev: pins and the @biomejs/biome@2.3.10 entry in .pre-commit-config.yaml. The diff to renovate.json5 adds "pre-commit": { enabled: true }, which …
Out of Scope Changes check Passed The only changed file is renovate.json5. Both functional additions (the pre-commit manager enablement and the npm custom manager) map directly to #460. The added comments describe the same changes…
Full details: Title check

Explanation

The title "chore(renovate): track pre-commit hook revisions" matches the main change. The PR enables Renovate's pre-commit manager so it tracks the 13 rev pins in .pre-commit-config.yaml. It also adds a custom regex manager for npm packages in additional_dependencies, which the title does not mention. The title is specific, concise, and follows conventional commit style.

Full details: Linked Issues check

Explanation

Issue #460 requires Renovate to track the 13 rev: pins and the @biomejs/biome@2.3.10 entry in .pre-commit-config.yaml. The diff to renovate.json5 adds "pre-commit": { enabled: true }, which enables Renovate's pre-commit manager for the rev: pins. It also adds a regex custom manager with datasourceTemplate: "npm" and managerFilePatterns matching .pre-commit-config.yaml. Its matchStrings captures depName and currentValue from additional_dependencies entries of the form "@scope/name@x.y.z", which covers the Biome entry. The biome.json $schema item in #460 is handled centrally in DevSecNinja/.github. The issue assigns that item elsewhere, so this PR does not need to implement it. The config change is the only coding requirement. No automated test applies to this configuration. The PR states that renovate-config-validator was not run, so config validity is not confirmed by tooling. This does not change the verdict because the diff matches the requirement.

Full details: Out of Scope Changes check

Explanation

The only changed file is renovate.json5. Both functional additions (the pre-commit manager enablement and the npm custom manager) map directly to #460. The added comments describe the same changes and do not add behavior. No unrelated files or settings were changed. The custom manager's regex matches only additional_dependencies entries, and the pre-commit manager handles the rev: pins. The changes do not overlap in a way that adds unrelated scope.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a7d320c0-0481-437a-88d0-3283c4886a1b
Commits

Reviewing files that changed from the base of the PR and between 03f4b2a and f52ddd0.

Files selected for processing: 1

  • renovate.json5

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified for the Renovate pre-commit dependency tracking changes.

No open issues 🎉

What changed in this PR

Adds Renovate tracking for hadiscover’s pre-commit dependencies, addressing the coverage gap in #460.

Changes:

  • Enables the built-in pre-commit manager to track the 13 hook revision pins.
  • Adds a custom regex manager for npm additional_dependencies, covering the pinned Biome package.
File Description
renovate.json5 Enables hook revision updates and adds npm dependency tracking for pre-commit configuration.

Review effort: Balanced

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Renovate doesn't update the pre-commit hook revisions

2 participants