Conversation
Added NetworkMode model for - labels, states - icons - bitmasks - cycle order - legacy readback mappings
- Corrected the NUMBER_PATTERN Java string escape. - Changed `\d+` to `\\d+` so the regular expression compiles correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR completes Phase 1 of the NetToggle modular refactor.
It centralizes preferences and shared models while preserving the existing application behavior, saved preference values, Target SIM handling, and four-mode Quick Settings tile cycle.
New Modules
AppPreferencesas the central preference manager.ExecutionModefor None, Root, and Shizuku modes.TargetSimfor Auto, SIM 1, and SIM 2 selection.NetworkModefor network mode states, labels, icons, bitmasks, default cycle order, and legacy readback mappings.Updated Components
BootReceiverto clear transient state throughAppPreferences.MainActivityto use the shared preference and model classes.NetworkTileServiceto use centralized network mode definitions.Behavior Preserved
Existing SharedPreferences values remain compatible with v1.0.32.
Root and Shizuku execution modes remain unchanged.
Auto, SIM 1, and SIM 2 Target SIM behavior remains unchanged.
Network mode readback continues to use subscription IDs.
Network mode application continues to use physical SIM slot indexes.
Cached QS tile state behavior remains unchanged.
Boot and package-update cache reset behavior remains unchanged.
Existing QS tile cycle remains:
4G Only → 5G Only → Preferred 5G → Preferred 4G