Skip to content

ENG-2067 Refactor publishNodesToGroups to avoid database access in loops - #1248

Merged
maparent merged 3 commits into
mainfrom
eng-2067-refactor-publishnodestogroups-to-avoid-database-access-in
Jul 31, 2026
Merged

ENG-2067 Refactor publishNodesToGroups to avoid database access in loops#1248
maparent merged 3 commits into
mainfrom
eng-2067-refactor-publishnodestogroups-to-avoid-database-access-in

Conversation

@maparent

@maparent maparent commented Jul 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

@linear-code

linear-code Bot commented Jul 26, 2026

Copy link
Copy Markdown

ENG-2067

@vercel

vercel Bot commented Jul 26, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
discourse-graph Skipped Skipped Jul 31, 2026 1:42pm

Request Review

@supabase

supabase Bot commented Jul 26, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

graphite-app[bot]
graphite-app Bot reviewed Jul 26, 2026
View reviewed changes
Comment thread apps/roam/src/utils/publishNodesToGroups.ts
Comment thread packages/database/src/lib/groups.ts
devin-ai-integration[bot]
devin-ai-integration Bot reviewed Jul 26, 2026
View reviewed changes

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 4 potential issues.

View 2 additional findings in Devin Review.

Open in Devin Review

Comment thread apps/roam/src/utils/publishNodesToGroups.ts
Comment thread apps/roam/src/utils/publishNodesToGroups.ts
Comment thread apps/roam/src/utils/publishNodesToGroups.ts Outdated
Comment thread packages/database/src/lib/groups.ts
@maparent
maparent force-pushed the eng-2067-refactor-publishnodestogroups-to-avoid-database-access-in branch from ab026af to 05ce8da Compare July 27, 2026 01:27
@maparent
maparent requested review from mdroidian and sid597 July 27, 2026 10:36
@maparent
maparent force-pushed the eng-2067-refactor-publishnodestogroups-to-avoid-database-access-in branch from 4e8d0a4 to 9792f5d Compare July 27, 2026 15:32
@mdroidian Linear Code

mdroidian commented Jul 28, 2026

Copy link
Copy Markdown
Member

@codex review

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Jul 28, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9792f5d5bc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/roam/src/utils/publishNodesToGroups.ts
Comment thread apps/roam/src/utils/publishNodesToGroups.ts
mdroidian
mdroidian approved these changes Jul 31, 2026
View reviewed changes

@mdroidian mdroidian left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See codex comments

@maparent
maparent merged commit b6ea830 into main Jul 31, 2026
12 checks passed
@maparent
maparent deleted the eng-2067-refactor-publishnodestogroups-to-avoid-database-access-in branch July 31, 2026 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments
@devin-ai-integration devin-ai-integration[bot] devin-ai-integration[bot] left review comments
@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments
@mdroidian mdroidian mdroidian approved these changes
@sid597 sid597 Awaiting requested review from sid597

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maparent @mdroidian