fix: parse whole-unit market search prices - #375
Open
tarikermis wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #346
Steam renders whole-unit market prices with
--in the cents position, for example1,--€. The current parser strips non-digits, so that value becomes 1 cent instead of 100 cents.This replaces the terminal
--placeholder with00before the existing digit-only normalization. Decimal prices and localized thousands separators keep their current behavior.Verification
1,23€,$1.23,1,--€,$1.--, and1.234,--€; all produced the expected cent values.node --check classes/CMarketSearchResult.jsgit diff --checkThe repository has no configured test script.
Best Regards, Tarik