Repository navigation
update Pidgeon, Pidgeon domain verification: version 2 with groups - #3218
Open
patrickcneuhaus wants to merge 1 commit into
Open
patrickcneuhaus wants to merge 1 commit into
patrickcneuhaus wants to merge 1 commit into
Conversation
|
✅ JSON Filename Check Passed |
|
✅ JSON Schema Validation Passed |
PR Description Check PassedAll required sections are filled in correctly. Details |
Linter OK
|
| Level | Code | Note |
|---|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Version 2 of
pidgeon.ai.verify(merged in #3094, live at Cloudflare since 19 November). Each record now has its owngroupId:ownershipfor the_pidgeonTXT that proves the domain, andagent-signingfor thepgn2._domainkeyCNAME to Pidgeon's DKIM key. A customer can then prove ownership without delegating a DKIM selector; applying withoutgroupIdstill writes both, as version 1 did. Cloudflare suggested the split when onboarding version 1. ThelogoUrlmoves to a square PNG that is served directly (the old SVG path no longer is), and the description names the groups.Type of change
How Has This Been Tested?
<providerId>.<serviceId>.jsonlogoUrlis actually served by a webserverdc-template-linter -merge-or-fail -tolerate warn -logosexits 0.Checklist of common problems
syncPubKeyDomainis setwarnPhishingis not set alongsidesyncPubKeyDomainsyncRedirectDomainis set whenever the template usesredirect_uriin the synchronous flowtxtConflictMatchingModeis set on every TXT record that must be unique per label or content prefixpidgeon-verify=%token%)hostlabel (_pidgeonis fixed)hostfield to create a subdomain%host%does not appear explicitly in anyhostattributeessentialis set toOnApplyon records the end user may need to modify or remove without breaking the template (the CNAME; the TXT is the verification itself)Online Editor test results
Editor test link(s):
Test pidgeon.ai/verify example.com/@
Test pidgeon.ai/verify example.com/agents
Test pidgeon.ai/verify example.com/@, group ownership only