Skip to content

Fix the three tests that fail on main - #5

Draft
Doringber wants to merge 1 commit into
mainfrom
cursor/fix-preexisting-test-failures-083e
Draft

Doringber wants to merge 1 commit into
mainfrom
cursor/fix-preexisting-test-failures-083e

Conversation

@Doringber

Copy link
Copy Markdown
Owner

What

The CI job on main was already red before the readiness work. These are the three failures.

  • tests/test_version.py compared the resolver to the hardcoded string 0.1.1 after VERSION moved to 0.1.2. Both tests now read VERSION and assert the resolver matches that file, so the next bump does not break them.
  • test_cursor_agent_client_normalizes_malformed_tool_payloads expects a non-object mcpToolCall to fail the run. _tool_payload treated a list as an empty object and reported success. mcpToolCall and getMcpToolsToolCall now raise ValueError when the value is not an object, which the client reports as Malformed Cursor agent response.

Tests

  • Added a parametrized parser test for both payload keys.
  • CI selection: 266 passed, 22 deselected, coverage 87.87% (threshold 85%). The three previous failures are gone.
Open in Web Open in Cursor 

Version tests now compare against the VERSION file so a bump does not
leave them stale. A non-object mcpToolCall or getMcpToolsToolCall fails
the run as a malformed Cursor response.

Co-authored-by: Dor Ingber  <Doringber@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants