Conversation
Separate descriptor bindings from protocol ownership under a namespace-wide port authority. Inherit accepted-child identities independently, enforce both-sided reuse rules, and retain explicit bindings across refused connections. Transfer unreachable TIME_WAIT sockets to compact smoltcp storage without dropping tuple protection. Maintain expiry in direct and NAPI polling and refresh the protocol clock under its locks so idle safe reuse does not depend on unrelated traffic. Pin smoltcp 98c706ee7d5e62c77f74278531402637482a70bc and add 31 mandatory lifecycle regression tests. Validate with make fmt, make kernel, 168 existing guest network cases, 671 dependency tests, dual-stack nginx restart cycles, real 60-second expiry, and 40000 connections in each active-close direction. Signed-off-by: longjin <longjin@dragonos.org>
Member
Author
|
@codex review |
Update the manifest and lockfile to the merge commit of DragonOS-Community/smoltcp#33 on dragonos/v0.12.0. The merged tree is identical to the previously validated dependency revision. Verify the updated dependency with make kernel. Signed-off-by: longjin <longjin@dragonos.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix TCP port ownership and TIME_WAIT reuse rather than releasing all protection when a descriptor closes.
Dependency: DragonOS-Community/smoltcp#33 is merged into
dragonos/v0.12.0. Pin its merge commit9b9813e25323fb574f80b8aebfbbf2e7809f47ab; its Git tree is identical to the previously validated revision.Validation
make fmt,make kernel, and whitespace checks passed.The 2,000-connection median changed from 905.7ms to 925.9ms (about +2.2%) while retaining the previously discarded protocol protection. Fixed-server-port batches remained approximately flat through 40,000 historical closes. Peak memory includes retained protocol records and allocator/container capacity; this is not a zero-cost compatibility change.
Scope
Dynamic migration of the same local IP between interface-owned protocol stacks remains a separate issue. Ordinary route/egress changes are not that migration case. This change does not relax tuple protection to hide that limitation and does not add a general TCP sysctl or recoverable-allocation framework.