Closed
test(ErrorService): add behavioral tests for redirectError, redirectIfError, and redirectIfDenied#291
Conversation
Going forward the main differences in usage are:
```diff
apollo
.query({query: myQuery})
.pipe(
+ ignoreErrors(),
map(result => result.data.myQuery),
);
```
```diff
apollo
.watchQuery({
query: myQuery,
+ notifyOnNetworkStatusChange: false,
})
.valueChanges
.pipe(
+ onlyCompleteData(),
map(result => result.data.myQuery),
);
```
Alos, Natural has a new `createErrorLink()`, with related
tests moved from Epicerio. To make it reasonnable a feature-complete
`ErrorService` now also lives in Natural, instead of in each projects
with very minor differences.
…IfError and redirectIfDenied
Copilot
AI
changed the title
[WIP] Fix code based on review comment 290
test(ErrorService): add behavioral tests for redirectError, redirectIfError, and redirectIfDenied
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ErrorServicespec only asserted construction; the three core methods had no test coverage.Changes
error.service.spec.ts: Expanded the spec with behavioral tests covering:redirectError()— navigates to/errorwithskipLocationChange, stores the error, and captures the originating hrefredirectIfError()— redirects and rethrows on observable error; passes values through on successredirectIfDenied()— redirects onfalse; passestruethrough without navigatingAll subscribe callbacks include explicit
errorhandlers (done.fail/fail) to surface unexpected errors as clear test failures.