Conversation
furtib
force-pushed
the
test_into_bazel_004
branch
from
September 23, 2026 13:50
4b0e76d to
12cc401
Compare
furtib
force-pushed
the
test_into_bazel_004
branch
from
September 23, 2026 16:14
12cc401 to
ce5ec7b
Compare
Szelethus
reviewed
Sep 24, 2026
Szelethus
left a comment
Szelethus
left a comment
Collaborator
There was a problem hiding this comment.
I really like the test targets in BUILD. I suppose when its reasonable, it pays to adhere to the builtin py_test rule.
I respect that CodeChecker store/parse are very different from most of the other tests (similarly to external deps), so some leniency is in order.
| # Basename of the analysis output directory produced by codechecker_test. | ||
| REPORT_DIR_NAME = "codechecker-files" | ||
|
|
||
| def resolve_report_data(paths: list[str]) -> str: |
Collaborator
There was a problem hiding this comment.
This seems quite a bit of logic for a test. Is it that impossible to know the location of the directory to parse?
Comment on lines
+164
to
+170
| "store", | ||
| report_dir, | ||
| "-n", | ||
| name, | ||
| f"--url=http://localhost:{port}/Default", | ||
| "--zip-loc", | ||
| zip_loc, |
Collaborator
There was a problem hiding this comment.
Is this mandated by pylint? Some grouping would be nicer.
Suggested change
| "store", | |
| report_dir, | |
| "-n", | |
| name, | |
| f"--url=http://localhost:{port}/Default", | |
| "--zip-loc", | |
| zip_loc, | |
| "store", | |
| report_dir, | |
| "-n", name, | |
| f"--url=http://localhost:{port}/Default", | |
| "--zip-loc", zip_loc, |
| """ | ||
| Stops the CodeChecker server started by start_codechecker_server | ||
| """ | ||
| # Idempotent: the object is also stopped from __del__, so avoid |
Collaborator
There was a problem hiding this comment.
That raises questions whether __del__ is helping or hindering the cleanup.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
We want all tests to be run with
bazel test //....What:
Note:
--zip-loc is only available since CodeChecker 6.27.x
Addresses:
#210