docs(resources): close out the Loader-split effort with final cleanup (Slice 4/4)#417
Merged
Merged
Conversation
Fixes documentation left stale by Slices 1-3's extractions (two
dangling {@link} references and two prose mentions of fields/methods
that moved to AssetResidency), documents the Loader constructor's
storeResource-callback ordering dependency in code instead of only in
an now-archived plan, and adds a brief architecture note to Loader's
class-level doc describing the three-collaborator composition.
Also collapses a byte-identical duplicate method pair
(_hasResource/_hasStored) introduced across Slice 3's fix rounds,
tightens 4 AssetResidency methods with no cross-class caller from
public @internal to private, and completes AssetResidency.destroy()'s
background-queue teardown (previously left the active/loaded/total
counters and a pending awaitBackground() resolver untouched).
No public API change, no behavior change — every item here is
doc-only, a visibility tightening with zero external callers, a
verified-identical duplicate collapse, or a destroy()-time-only
completeness fix. This closes the 4-slice internal Loader-split effort
(AssetTypeRegistry, AssetDecoder, AssetResidency, this cleanup pass).
Exoridus
enabled auto-merge (squash)
July 26, 2026 06:38
Bundle ReportChanges will increase total bundle size by 1.93kB (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: exo-esm-modules-esmAssets Changed:
Files in
Files in
view changes for bundle: exo-iife-min-Exo-iifeAssets Changed:
Files in
view changes for bundle: exo-full-iife-Exo-iifeAssets Changed:
view changes for bundle: exo-esm-esmAssets Changed:
Files in
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{@link}JSDoc references and two prose mentions of fields/methods that moved toAssetResidencyin Slice 3.Loaderconstructor'sstoreResource-callback ordering dependency in code (previously only in the now-archived plan), and adds a brief@remarksarchitecture note toLoader's class-level doc describing the three-collaborator composition (AssetTypeRegistry/AssetDecoder/AssetResidency)._hasResource/_hasStored) inAssetResidency.ts.public @internaltoprivate(the other 2 candidates were correctly keptpublic @internalafter review found real test-suite callers for them).AssetResidency.destroy()fix: the background-queue teardown now also resets the active/loaded/total counters and resolves a pendingawaitBackground()promise, instead of leaving them stale after a full teardown.Test plan
pnpm typecheck— cleanpnpm test:core— 330/330 files, 5344 passed, 15 skipped, 0 failedpnpm verify:quick(typecheck + guides/examples/type-tests/packages typecheck + lint + format + docs:api:check) — clean, only pre-existing unrelated warningspnpm docs:api:check— confirms zero public API driftLoader.tsonly, missing real callers intest/resources/asset-residency.test.ts) — fixed and re-verified. Final whole-branch review: ready to merge, no blocking findings.