[Part 21] Remove Onyx.connect from LocalePhoneNumber#97022
Merged
mountiny merged 1 commit intoJul 26, 2026
Merged
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
marufsharifi
marked this pull request as ready for review
July 25, 2026 18:26
melvin-bot
Bot
requested review from
heyjennahay and
shubham1206agra
and removed request for
a team
July 25, 2026 18:26
|
@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
melvin-bot
Bot
requested review from
a team and
JmillsExpensify
and removed request for
a team
July 25, 2026 18:26
Contributor
|
@marufsharifi Please fix the test case and recordings. |
Contributor
Reviewer Checklist
Screenshots/VideosScreen.Recording.2026-07-26.at.9.00.35.AM.mov |
shubham1206agra
approved these changes
Jul 26, 2026
JmillsExpensify
left a comment
Contributor
There was a problem hiding this comment.
No product review required
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
This PR removes another focused
LocalePhoneNumber.formatPhoneNumberdependency from the report action context-menu copy-message path.ContextMenuActionsno longer importsformatPhoneNumberdirectly fromLocalePhoneNumber. Instead,BaseReportActionContextMenupasses the active localizedformatPhoneNumberfromuseLocalize()through the context-menu action payload.User-facing behavior should stay the same. Copying reimbursement queued report action messages should still produce the same copied text, but this path now uses the active localized formatter so we can continue moving toward removing
Onyx.connect()fromLocalePhoneNumber.Fixed Issues
$ #66327
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screencast.From.2026-07-25.11-52-51.webm