Clear transaction holds when marking a submit-and-close report as done

[MelvinBot]

Explanation of Change

When a track-intent user holds a track-distance expense and then taps More → Mark as done on a submit-and-close workspace, the report transitions straight to CLOSED, but the "expense is on hold" status bar keeps rendering in the report header.

The hold signal lives on the transaction via transaction.comment.hold, and the on-hold banner in useMoneyReportHeaderStatusBar is derived purely from that field with no report-status gate. submitReport() optimistically set the report to CLOSED but never cleared the hold on its held transactions — so isOnHold() stayed true and the banner lingered. The sibling approveMoneyRequest flow already clears holds optimistically; the submit path did not.

This change adds an optimistic hold-clear in submitReport() for the submit-and-close path (when the report goes straight to CLOSED), mirroring the existing approveMoneyRequest block, with a matching failureData restore so a server rejection rolls the hold back.

Fixed Issues

$ #91781
PROPOSAL: #91781 (comment)

Tests

1. Log in to a new account and select "Track expenses for my business" during onboarding (this creates a submit-and-close workspace).
2. Open the workspace chat and create a track distance manual expense.
3. Long press the expense preview and select Hold, entering a reason.
4. Tap More → Submit ("Mark as done").
5. Verify the header no longer shows the "expense is on hold" message after the report is marked as done.

• Verify that no errors appear in the JS console

Offline tests

1. Repeat the steps above while offline.
2. Verify the hold banner disappears optimistically the moment the report is marked as done.

QA Steps

Same as tests.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

AI Tests (run by MelvinBot)

• npm run fmt (oxfmt) on the repo — both changed files formatted clean
• npm run lint-changed (eslint) — clean
• npm run typecheck-tsgo — passed
• npm test -- tests/actions/IOUTest/ReportWorkflowTest.ts — 84/84 passed, including a new test: "clears the hold on held transactions when submitting a Submit and Close report"

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[MelvinBot]

There's no code fix to push here — the only failing check is PR Author Checklist / checklist, and it's failing because the checklist boxes are unchecked (1 of 38 completed), not because of anything in the diff.

Every actual CI check is green: Bun tests, all 8 test jobs, typecheck, ESLint, Oxfmt, React Compiler Compliance, Storybook, builds, spellcheck, knip, and unused-styles all pass.

The author checklist is a human attestation (confirming you tested on all platforms, checked for console errors, etc.), so I can't and shouldn't tick those boxes on your behalf. To clear it, complete the checklist in the PR description and the check will re-run green.

_{Note: baseline-perf-tests / branch-perf-tests were still running when I checked — those are informational performance-comparison jobs and don't block merge.}