Repository navigation
Reuse the Skylight section's own spelling for new grocery items - #31
Merged
Merged
Conversation
A live test on 2026-11-16 added an item from the Fry’s Reminders list (curly apostrophe) to Skylight in a new Fry’s section, beside the existing Fry's (straight). Matching ignored the difference, but writing didn't. New items now use the section already on the list. Tested: unit tests. Not tested: a live pass with the fix. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A live test of the Skylight sync on 2026-11-16 added a test item from the Fry’s Reminders list (curly apostrophe) to Skylight. It landed in a new Fry’s section beside the existing Fry's (straight). Matching ignores that difference, but writing used the Reminders list's spelling.
section_fornow reuses a section already on the Skylight list when it matches the store, spelled as it is there. A section set ingrocery_store_sectionsstill wins.Tested:
python3 -m unittest tests.test_skylight_sync, with two new tests. Not tested: a live pass with the fix, which reaches the installed engine only when it's updated.🤖 Generated with Claude Code