Refactor fdpApi and add fetchUtils - #75
Merged
mihailefter merged 7 commits intoSep 3, 2026
Merged
Conversation
dennisvang
marked this pull request as draft
September 2, 2026 15:52
and rename fetchApiDocs to fetchJSON. This allows us to remove the cyclic imports between fdpApi and apiDocs.
dennisvang
marked this pull request as ready for review
September 3, 2026 07:54
Collaborator
|
Hi @dennisvang! This is a real improvement, thanks. I pushed a few small changes on top: converted I’ll squash and merge this entire stack now to complete this and close the corresponding issue, if you agree. |
This was referenced Sep 3, 2026
Collaborator
Author
|
Hi @mihailefter well spotted, somehow I missed that Yes, please, go ahead with the merge (this will close #34 automatically). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves the bindOperation calls to fdpApi.ts to improve cohesion.
Also moved the generic
requestandfetch*functions fromfdpApiinto a separatefetchUtilsmodule to prevent circular imports betweenapiDocsandfdpApi, and renamedfetchApiDocstofetchJSON.@mihailefter these are just some quick-and-dirty changes to illustrate what I had in mind in my review of #64
Feel free to ignore, or modify to your liking. 🙂
todo:
fetchRdfTurtle,fetchApiDocsand related functions into a separate module?