[feat] 프론트엔드 주요 기능 구현 및 UI 개선 #398
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| name: 'Chromatic Deployment' | ||
|
|
||
| on: pull_request | ||
|
|
||
| jobs: | ||
| chromatic: | ||
| name: 'Run Chromatic' | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 | ||
|
|
||
| - run: yarn | ||
|
|
||
| - uses: chromaui/action@latest | ||
| id: chromatic | ||
| with: | ||
| projectToken: ${{ secrets.CHROMATIC_PROJECT_TOKEN }} | ||
| token: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| - name: comment PR | ||
| uses: thollander/actions-comment-pull-request@v1 | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| with: | ||
| message: '🚀storybook: ${{ steps.chromatic.outputs.storybookUrl }}' | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,3 +25,9 @@ dist-ssr | |
| .env.local | ||
| # Local Netlify folder | ||
| .netlify | ||
|
|
||
| # TypeScript build cache | ||
| *.tsbuildinfo | ||
|
|
||
|
|
||
| *storybook.log | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| import type { StorybookConfig } from '@storybook/react-vite'; | ||
|
|
||
| const config: StorybookConfig = { | ||
| stories: ['../src/**/*.mdx', '../src/**/*.stories.@(js|jsx|mjs|ts|tsx)'], | ||
| addons: [ | ||
| '@storybook/addon-essentials', | ||
| '@storybook/addon-onboarding', | ||
| '@chromatic-com/storybook', | ||
| ], | ||
| framework: { | ||
| name: '@storybook/react-vite', | ||
| options: {}, | ||
| }, | ||
| }; | ||
| export default config; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| import type { Preview } from '@storybook/react'; | ||
|
|
||
| const preview: Preview = { | ||
| parameters: { | ||
| controls: { | ||
| matchers: { | ||
| color: /(background|color)$/i, | ||
| date: /Date$/i, | ||
| }, | ||
| }, | ||
| }, | ||
| }; | ||
|
|
||
| export default preview; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚨 issue (security): workflow에서
GITHUB_TOKEN에pull-requests: write권한을 선언하지 않았습니다. 따라서 기본 읽기 전용 토큰을 사용하는 저장소에서는 PR 댓글을 생성하거나 업데이트할 수 없고, Chromatic이 성공하더라도 마지막 단계가 실패합니다.트리거: 저장소의 workflow 토큰이 기본적으로 읽기 전용 권한을 사용할 때 발생합니다.
권장 수정: 최상위에
permissions: pull-requests: write를 선언하거나 필요한 job 수준 권한을 설정하세요.Original comment in English
🚨 issue (security): The workflow does not declare
pull-requests: writepermissions forGITHUB_TOKEN, so repositories using the default read-only token cannot create or update the PR comment and the final step fails despite Chromatic succeeding.Triggers: When the repository's workflow token defaults to read-only permissions.
Suggested fix: Add a top-level
permissions: pull-requests: writedeclaration, or configure the required job-level permission.