Add support for commit and decommit hooks - #1
Open
javelina-pkwy wants to merge 1 commit into
Open
javelina-pkwy wants to merge 1 commit into
javelina-pkwy wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am working on a FEX change to keep more accurate track of our true footprint in physical memory, and these two trampolines are needed for that.
This feature will eventually accrue, hopefully, to better support LibCEF apps like MATLAB for Linux. Chromium sets RLIMIT_DATA to a reasonable value (ie. 16GB) but at present various allocations internal to FEX pollute the kernel's accounting of how many pages we are actually using. Running simple programs can show
VmDataon the order of TBs, and if RLIMIT is set some syscalls will fail with an OOM condition. Most of that several TB's comes from how the host stack is allocated, but once that is fixed the biggest culprit are rpmalloc buffers which eat up multiple gigabytes per thread.