AssetId support for adapters - #8
Open
sondre81 wants to merge 5 commits into
Open
Conversation
- updated readme - updated to use LdapNameGeneratorUtil - added and made tests for LdapNameGeneratorUtil - added adapter dependent resource test - added tests for adapter - added assets to fint adapter - updated ghactions - added dependabot
sivertheisholt
left a comment
sivertheisholt
left a comment
There was a problem hiding this comment.
Good work, I dont know this operator that much, so left a few comments regarding assets/assetIds that im confused on. Should maybe also get @murillio4 to look over.
sondre81
marked this pull request as ready for review
May 6, 2026 12:37
murillio4
requested changes
May 6, 2026
There was a problem hiding this comment.
I think using a naming convention similar to whats purposed in kafkarator PR 7 is better.
I think the method is more appropriate because its simpler, and reproducible. Especially since it uses a hash instead of using RandomStringUtils.randomAlphabetic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for assetId in adapters (FLA-191). Had to rework (FLA-839) as there became a lot of merge conflicts after stalling previous PR.
Made changes to GH Actions so it's easier to deploy and test in test environment after PR is completed.
Work done: