Repository navigation
seo: publish the rule reference on the Pages site - #128
Merged
Merged
Conversation
The Pages homepage linked to docs/rules/{blast-radius,drift,nplusone}.md,
but docs/ was excluded from the build, so all three links returned 404.
Publishing docs/rules fixes them and gives the site pages of its own:
each rule answers a question people search for (.count() > 0 vs
.exists(), datetime.now() vs timezone.now(), N+1 in a loop), while the
homepage only duplicates the GitHub README.
DOL012.md and blast-radius.md stay out: they quote {{ ... }} (a Django
template variable, a GitHub Actions expression) that Liquid would render
as empty text. Links to those two now point at GitHub.
|
Warning Review limit reachedNext included review available in 25 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/rules/{blast-radius,drift,nplusone}.mdreturned 404 becausedocs/was excluded from the Jekyll build.docs/rulesis published (21 pages), each with a unique title from its H1 via jekyll-titles-from-headings.DOL012.mdandblast-radius.mdstay excluded: they contain{{ ... }}that Liquid would silently blank; links to them now point at GitHub.docs/i18nstays excluded.