Skip to content

Don't even suggest removing async on overrides #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ejball wants to merge 2 commits into
base: master
Choose a base branch
from
+2 −2
Open

Don't even suggest removing async on overrides #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b57eb3
Don't even suggest removing async on overrides
ejball Aug 21, 2026
fecddc8
Update generated C# editorconfig
ejball Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion conventions/editorconfig-csharp/files/.editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ dotnet_diagnostic.IDE0305.severity = suggestion
dotnet_diagnostic.IDE0306.severity = suggestion
dotnet_diagnostic.IDE0370.severity = suggestion
dotnet_diagnostic.IDE0390.severity = suggestion
dotnet_diagnostic.IDE0391.severity = suggestion
dotnet_diagnostic.IDE0391.severity = none
dotnet_diagnostic.IDE1005.severity = suggestion
dotnet_diagnostic.NUnit2045.severity = suggestion
dotnet_diagnostic.SA0001.severity = none
Expand Down
2 changes: 1 addition & 1 deletion sections/csharp/editorconfig.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,7 @@ As of this writing, detection of unnecessary nullable warning suppressions using

```editorconfig
dotnet_diagnostic.IDE0390.severity = suggestion
dotnet_diagnostic.IDE0391.severity = suggestion
dotnet_diagnostic.IDE0391.severity = none
```

We prefer to use the `async` keyword for cleaner code, even when it is less efficient than returning `Task.FromResult` or `Task.CompletedTask`.
Expand Down