Repository navigation
2.0 phase 1, PR 1: app skeleton and Core winget CLI reads - #33
Merged
Merged
Conversation
First step of phase 1 (ADR 0023-0027). app\ holds the solution: an empty WPF window on the Fluent theme, asInvoker, and WinGetStudio.Core with the exit-code table, a process runner without cmd (CreateProcess with output files and a handle list, wait on the process only), argument quoting for CommandLineToArgvW, the column-position parser and the CLI readers (search, list, upgrade, pin list, details) under one global lock. The 75 tests port the fixtures of tests\Test-InvokeWinGet.ps1. global.json pins the .NET 10 SDK and opts dotnet test into Microsoft.Testing.Platform; CI gets a dotnet job. Co-Authored-By: Claude <noreply@anthropic.com>
This was referenced Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of five pull requests for phase 1 of 2.0 (C# on .NET 10 WPF, ADR 0023-0027). Nothing in
src/,ui/ortests/*.ps1changes.What is in it
app/WinGetStudio.sln:WinGetStudio(an empty WPF window,ThemeMode="System",asInvoker, PerMonitorV2),WinGetStudio.Core,WinGetStudio.Core.Tests(xUnit v3).global.json: .NET 10 SDK, 10.0.100 or a later 10.0 feature band, no previews (ADR 0026). It also optsdotnet testinto Microsoft.Testing.Platform, which xUnit v3 needs on SDK 10.ExitCodes: the table fixed in v1.13 (PR fix: exit codes, cmd expansion, signed self-update, import arguments #31).ProcessRunner:CreateProcesswithoutcmd. stdout and stderr go to files,PROC_THREAD_ATTRIBUTE_HANDLE_LISTlimits inheritance to them and NUL, and the wait is on the process alone (ADR 0004, ADR 0025). Output is read as UTF-8, and leftoverwgt_*files are cleaned byTempFiles.CommandLine: quoting forCommandLineToArgvW; no shell sees the arguments.WinGetTable: the column-position parser (ADR 0006), plus the output tail and the details text.WinGetCli : IWinGetBackend: search (winget, then msstore), installed, upgrades, pins and details, with the same behaviour as 1.x. It also adds:-, no control characters);--no-progressfrom winget 1.29.dotnetjob (setup-dotnet 10.0.x, build Release,dotnet test).Tests
75 tests, ported from the fixtures of
tests/Test-InvokeWinGet.ps1:cmd.exeandping(a detached child, UTF-8, a negative exit code, the tick);CommandLineToArgvW.Run locally:
Test-InvokeWinGet.ps1andTest-Ui.ps1: green;Notes
winget --version(under the lock), not from the App Installer package as in 1.x: reading the package needs the WinRT projection, which would add tens of MB to the ~200 KB framework-dependent exe. To be measured before the winget setup (PR 4) and COM (phase 4).Next pull requests
🤖 Generated with Claude Code