Repository navigation
FerroUI main: subscription guards - #5
Merged
Merged
Conversation
The submodule moves to FerroUI main at b75373981, where the event, timer, property-observation and other subscription APIs return a Subscription guard that removes its handler when dropped (#423 D4/D5).
The closing handler of the main window (it commits the edit in progress before the window closes) detaches its Subscription guard, which would otherwise remove the handler when it is dropped. The timers of the prototype runtime and the pending save, which the app stops itself, are held as Subscription guards.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the FerroUI submodule to main (b75373981), where the subscription APIs return a
Subscriptionguard that removes its handler when dropped (FerroUI #423, D4/D5).closinghandler (it commits the edit in progress before the window closes) callsdetach(): without it the handler would have been removed as soon as it was added.Subscription.cargo check --workspace --all-targets(Rust 1.99, the app's toolchain) reports no unused guard.