Repository navigation
FerroUI 4702de41a: the size work, Locale text cultures and url::Url keys - #6
Merged
Merged
Conversation
The FerroUI submodule moves to the latest main, which carries the size work (theme trimming on by default, the trimmed type tables and registrations), with the workspace blocks written by sync-workspace.py and the lock file to match. Formatted text takes an icu Locale now (Locale::UNKNOWN for the invariant culture), the embedded font collection takes url::Url keys, and the XAML loader takes a UriRef.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the FerroUI submodule to main 4702de41a, which carries the binary size work (theme trimming on by default, trimmed type tables and registrations). The workspace blocks come from
FerroUI/scripts/apps/sync-workspace.pyand the lock file matches.API changes absorbed:
FormattedTextand text runs take an icuLocale.Locale::UNKNOWNreplacesCultureInfo::invariant_culture()in the five text-shaping calls.EmbeddedFontCollectiontakesurl::Urlkeys.FerroXamlLoader::loadtakes aUriRef.Tested locally on Rust 1.99:
cargo test --workspacepasses (324 tests). Two timing-based page tests from #2 (native_pages_rename_from_the_row_and_menu_keeps_selection_and_history,native_touch_page_hold_distinguishes_menu_reorder_and_scrolling) each failed once while the full suite ran in parallel under load. Both pass alone and with their module, and a third full run passed.