Repository navigation
FerroUI 0c0ea2a72, and a double-tap window for loaded test runs - #7
Merged
Merged
Conversation
The FerroUI submodule moves to main 0c0ea2a72 (control themes as tables, type identities, newer JDKs), with the workspace blocks written by sync-workspace.py. The headless platform stamps input with wall-clock time, and the default double-tap window is 500 ms; with the whole suite running in parallel the two clicks of a test's double click could fall outside it, and the page rename test failed now and then. The test fixture binds platform settings with a 5 s double-tap window in its locator scope.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the FerroUI submodule to main 0c0ea2a72, with the workspace blocks from
FerroUI/scripts/apps/sync-workspace.pyand the lock file to match. This picks up:is/cast no longer links a class's whole type data;ubuntu-latest(#621);Test fixture: headless input is stamped with wall-clock time, and the default double-tap window is 500 ms. With the full suite running in parallel, the two clicks of the page-rename test sometimes fell outside the window, so it failed intermittently. The fixture now binds platform settings with a 5 s double-tap window in its locator scope; all other settings come from
DefaultPlatformSettings.Tested locally on Rust 1.99: the full suite passes (324 tests). Across three loaded full runs,
native_pages_rename_from_the_row_and_menu_keeps_selection_and_historypassed every time.native_touch_page_hold_distinguishes_menu_reorder_and_scrollingstill fails intermittently under load: after a hold and a move, the page drag sometimes does not start (pages_tests.rs:431). It passes alone, and needs a separate look at the hold-to-reorder path.