Repository navigation
Keep the toolbar enabled while cards animate - #5
Merged
Merged
Conversation
Every move disabled New game, Restart, Undo, Hint, Auto move and Draw for the length of its animation, and the disabled style dims a casino button to 45 % opacity, so the whole toolbar blinked on each click. The actions already return early while input is blocked (input_blocked), so the buttons stay enabled; Undo still follows whether there is a move to undo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the toolbar blinking on every click.
Each move disabled New game, Restart, Undo, Hint, Auto move and Draw for the length of its card animation (
set_is_enabled(!busy)inCasinoView). TheButton.casino:disabledstyle dims a button to 45% opacity, so the whole toolbar flashed dark on each stock click or card move.Every one of those actions already returns early while input is blocked (
input_blocked(), which covers animations and dialogs), so disabling the buttons added nothing. The buttons now stay enabled, and Undo is still enabled only when there is a move to undo.Tested locally:
cargo test --workspacepasses.