Repository navigation
Avoid invalidations from the progress bar - #92
Merged
Merged
Conversation
matthieugomez
force-pushed
the
progressbar-buffer
branch
from
November 16, 2026 12:59
1ff9231 to
f581751
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #92 +/- ##
=======================================
Coverage ? 74.83%
=======================================
Files ? 12
Lines ? 1236
Branches ? 0
=======================================
Hits ? 925
Misses ? 311
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
@JuliaRegistrator register |
|
Comments on pull requests will not trigger Registrator, as it is disabled. Please try commenting on a commit or issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The progress bar printed piece by piece to
stdout, whose type is only known to beIO, so packages that addIOmethods (e.g. FilePathsBase, loaded by CSV) invalidatedshowprogress,solve_residuals!and every caller, such asregin FixedEffectModels. The bar is now rendered into a buffer and written throughinvokelatest, which is not inferred through: FixedEffects-owned invalidation roots from FilePathsBase drop from 2 to 0, and the printed bytes are identical. Bumps the version to 3.5.2.