Skip to content

Avoid invalidations from the progress bar - #92

Merged
eloualiche merged 2 commits into
FixedEffects:mainfrom
matthieugomez:progressbar-buffer
Nov 16, 2026
Merged

eloualiche merged 2 commits into
FixedEffects:mainfrom
matthieugomez:progressbar-buffer

Conversation

@matthieugomez

@matthieugomez matthieugomez commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

The progress bar printed piece by piece to stdout, whose type is only known to be IO, so packages that add IO methods (e.g. FilePathsBase, loaded by CSV) invalidated showprogress, solve_residuals! and every caller, such as reg in FixedEffectModels. The bar is now rendered into a buffer and written through invokelatest, which is not inferred through: FixedEffects-owned invalidation roots from FilePathsBase drop from 2 to 0, and the printed bytes are identical. Bumps the version to 3.5.2.

@codecov

codecov Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@14f0adc). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/utils/progressbar.jl 0.00% 14 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #92   +/-   ##
=======================================
  Coverage        ?   74.83%           
=======================================
  Files           ?       12           
  Lines           ?     1236           
  Branches        ?        0           
=======================================
  Hits            ?      925           
  Misses          ?      311           
  Partials        ?        0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@eloualiche
eloualiche merged commit ba53975 into FixedEffects:main Nov 16, 2026
6 checks passed
@matthieugomez

Copy link
Copy Markdown
Member Author

@JuliaRegistrator register

@JuliaRegistrator

Copy link
Copy Markdown

Comments on pull requests will not trigger Registrator, as it is disabled. Please try commenting on a commit or issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants