Skip to content

Avoid invalidations in row_group_slots! and spawn_for_chunks - #13

Merged
eloualiche merged 2 commits into
FixedEffects:mainfrom
matthieugomez:fix-invalidations
Nov 16, 2026
Merged

eloualiche merged 2 commits into
FixedEffects:mainfrom
matthieugomez:fix-invalidations

Conversation

@matthieugomez

Copy link
Copy Markdown
Member
  • row_group_slots!: compute strides with a loop instead of cumprod(collect(reverse(ngroupstup))), which compiles abstractly typed Base code.
  • @spawn_for_chunks: collect the tasks with a loop instead of a comprehension over a generator.

Loading CategoricalArrays no longer invalidates any GroupedArrays code (12 invalidation roots before). Groups are unchanged (tests pass with 1 and 4 threads; 1-, 2- and 3-column groupings checked against a Dict-based reference). Bumps the version to 0.3.6.

@codecov-commenter

codecov-commenter commented Nov 16, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 42.85714% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.22%. Comparing base (f45ed1f) to head (c057767).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
src/spawn.jl 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
+ Coverage   69.67%   73.22%   +3.54%     
==========================================
  Files           3        3              
  Lines         343      381      +38     
==========================================
+ Hits          239      279      +40     
+ Misses        104      102       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@eloualiche
eloualiche merged commit dd1bee1 into FixedEffects:main Nov 16, 2026
5 checks passed
@matthieugomez

Copy link
Copy Markdown
Member Author

@JuliaRegistrator register

@JuliaRegistrator

Copy link
Copy Markdown

Comments on pull requests will not trigger Registrator, as it is disabled. Please try commenting on a commit or issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants