Repository navigation
Fix distillation with integer teacher scores - #1613
Open
zhechen-cs wants to merge 1 commit into
Open
zhechen-cs wants to merge 1 commit into
zhechen-cs wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integer
pos_scoresandneg_scoresare accepted by the training dataset, but a batch containing only integer scores becomes a Long tensor in the embedder forward pass. Softmax then raises before the distillation loss can be computed.Construct teacher scores as float32 in both the shared embedder forward and BGE-M3's separate forward. Add CPU regressions using a small XLM-R encoder for the base embedder and M3's dense and unified modes, covering both distillation losses and comparing losses and parameter gradients with equivalent floating-point scores.
Fixes #1471.
Validation with PyTorch 2.14.1 and Transformers 5.19.0:
fd1a2bd, the new test file had 6 failures at softmax for integer scores and 6 passing controls.python -m pytest tests/test_embedder_teacher_scores.py tests/test_finetune_trainer_compat.py -q: 16 passed.git diff --checkpassed.The tests use randomly initialized weights on CPU. No GPU or cross-device training was run.