build(deps): bump esbuild, vite and vitest in /app - #167
Conversation
Removes [esbuild](https://github.com/evanw/esbuild). It's no longer used after updating ancestor dependencies [esbuild](https://github.com/evanw/esbuild), [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) and [vitest](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest). These dependencies need to be updated together. Removes `esbuild` Updates `vite` from 5.4.21 to 8.2.2 - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v8.2.2/packages/vite) Updates `vitest` from 2.1.9 to 4.1.11 - [Release notes](https://github.com/vitest-dev/vitest/releases) - [Changelog](https://github.com/vitest-dev/vitest/blob/main/docs/releases.md) - [Commits](https://github.com/vitest-dev/vitest/commits/v4.1.11/packages/vitest) --- updated-dependencies: - dependency-name: esbuild dependency-version: dependency-type: indirect - dependency-name: vite dependency-version: 8.2.2 dependency-type: direct:development - dependency-name: vitest dependency-version: 4.1.11 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
![obvious-autobuild-staging[bot]](https://avatars.githubusercontent.com/u/31830338?s=60&v=4){kind=small}
There was a problem hiding this comment.
Obvious Code Review
Verdict: COMMENT (1 Blocker)
Summary
Dependabot multi-bump: vite 5.4.21 → 8.2.2, vitest 2.1.9 → 4.1.11, esbuild removed (rolldown upstream). I verified the PR head empirically in a clean worktree:
npm cifails with ERESOLVE —@vitejs/plugin-react@4.7.0(from the unchanged^4.3.4range) peers onvite ^4.2 || ^5 || ^6 || ^7, not vite 8. CI's install step (.github/workflows/ci.yml:28,npm ci) goes red on this branch, and post-merge every fresh clone breaks without--legacy-peer-deps.- Forced past the conflict, the app itself is fully compatible with vite 8 / vitest 4: lint clean, tsc clean, 91/91 tests pass, vite 8 build + prerender succeed.
So the upgrade is sound — the dependency set is just incomplete. The fix is to bump @vitejs/plugin-react to ^6.1.1 (peer vite ^8.0.0) in this PR and regenerate the lock (@dependabot recreate after the manifest edit, or a companion commit).
Suggestions
app/package.json:40— When bumping the react plugin, consider@vitejs/plugin-react-oxc(vite 8 recommends it; also removes the deprecatedoptimizeDeps.rollupOptions/ invalidjsxrolldown warnings emitted by the babel-based plugin).
| "typescript-eslint": "^8.18.0", | ||
| "vite": "^5.4.11", | ||
| "vitest": "^2.1.8" | ||
| "vite": "^8.2.2", |
There was a problem hiding this comment.
Blocker · reliability — npm ci fails on this tree: vite 8.2.2 is outside @vitejs/plugin-react@4.7.0's peer range (vite: ^4.2.0 || ^5.0.0 || ^6.0.0 || ^7.0.0), so npm aborts with ERESOLVE ("Conflicting peer dependency: vite@7.3.6") — reproduced on the PR head with npm 10.8.2. CI's install step (.github/workflows/ci.yml:28) runs npm ci and will fail; after merge, every clone needs --legacy-peer-deps. Bump @vitejs/plugin-react to ^6.1.1 (peer vite ^8.0.0, engines ^20.19.0 || >=22.12.0) alongside this vite bump and regenerate the lockfile. Note: the app code itself is fine on vite 8/vitest 4 — forced past the conflict, lint, tsc, 91/91 tests, build, and prerender all pass.
Removes esbuild. It's no longer used after updating ancestor dependencies esbuild, vite and vitest. These dependencies need to be updated together.
Removes
esbuildUpdates
vitefrom 5.4.21 to 8.2.2Release notes
Sourced from vite's releases.
... (truncated)
Changelog
Sourced from vite's changelog.
... (truncated)
Commits
de1111arelease: v8.2.2cb77e2atest(ssr): add destructing assignment case for moduleRunnerTransform (#23308)9db0b61fix(ssr): rewrite computed key of destructing parameter (#23307)8413052fix: respectresolve.preserveSymlinkswhen resolving root (fix #23197) (#23...05a003efix(config): resolve sourcemap paths against sourcemap location (#23239)495d9fffeat(deps): widen@vitejs/devtoolspeer range to v0.5.0 (#23302)1d9fa39refactor: use JSON import attributes instead of readFileSync in constants (#2...2804636fix(css): don't pass empty targets to lightningcss (#23295)599b44btest(module-runner): simplify server-hmr tests (#23300)4a261f2test(module-runner): add TLA circular import case (#23299)Updates
vitestfrom 2.1.9 to 4.1.11Release notes
Sourced from vitest's releases.
... (truncated)
Commits
9bd8d46chore: release v4.1.11 (#10995)9851dbcfix(browser): trigger playwright/chromium gc on lower disk availability [back...db616d2chore: release v4.1.10 (#10718)bae52b5fix(vm): fix external module resolve error with deps optimizer query for enco...a7a61e7chore: release v4.1.9 (#10598)934b0f5fix(pool): prevent test run hang on worker crash (#10543) [backport to v4] (#...7fb2965fix(browser): wait for orchestrator readiness before resolving browser sessio...a518019fix: fiximportOriginalwith optimizer and query import [backport to v4] (#...e61f2ddchore: release v4.1.8e4067b3fix(browser): disable clientcdpAPI whenallowWrite/allowExec: false[ba...Maintainer changes
This version was pushed to npm by GitHub Actions, a new releaser for vitest since your current version.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.