Skip to content

Reject matrix-shaped Gaussian hypothesis means#4765

Merged
FlorianPfaff merged 2 commits into
mainfrom
agent/reject-matrix-gaussian-hypothesis-means
Jul 26, 2026
Merged

Reject matrix-shaped Gaussian hypothesis means#4765
FlorianPfaff merged 2 commits into
mainfrom
agent/reject-matrix-gaussian-hypothesis-means

Conversation

@FlorianPfaff

Copy link
Copy Markdown
Owner

Bug

WeightedGaussianHypothesis.__post_init__ called reshape(-1) before validating the state-mean shape. As a result, row matrices such as (1, n) and column matrices such as (n, 1) were silently accepted as ordinary one-dimensional mean vectors. This can conceal transposition or accidental batching errors at the hypothesis-construction boundary.

Fix

  • retain scalar means as length-one state vectors for backward compatibility
  • require all non-scalar means to be one-dimensional
  • reject row and column matrices with a targeted ValueError

Regression coverage

Added focused tests that verify:

  • (1, n) row means are rejected
  • (n, 1) column means are rejected
  • scalar one-dimensional-state means remain supported
  • ordinary one-dimensional means remain supported

Validation

  • focused isolated pytest exercise: 4 passed
  • python -m py_compile on the modified module and regression test
  • branch comparison: 2 commits ahead of main, 0 behind; 2 files changed

@github-actions

Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 25.71s
✅ JSON prettier 7 0 0 0 0.92s
✅ JSON v8r 7 0 0 4.3s
✅ MARKDOWN markdownlint 68 0 0 0 1.83s
✅ MARKDOWN markdown-table-formatter 68 0 0 0 0.63s
✅ PYTHON black 1701 255 0 0 103.24s
✅ PYTHON isort 1701 480 0 0 2.92s
✅ REPOSITORY betterleaks yes no no 2.43s
✅ REPOSITORY checkov yes no no 54.57s
✅ REPOSITORY gitleaks yes no no 16.23s
✅ REPOSITORY git_diff yes no no 0.51s
✅ REPOSITORY secretlint yes no no 71.68s
✅ REPOSITORY syft yes no no 5.78s
✅ REPOSITORY trivy-sbom yes no no 5.86s
✅ REPOSITORY trufflehog yes no no 31.53s
✅ YAML prettier 11 0 0 0 0.74s
✅ YAML v8r 11 0 0 11.53s
✅ YAML yamllint 11 0 0 0.61s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.6.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_BETTERLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@FlorianPfaff
FlorianPfaff marked this pull request as ready for review July 26, 2026 12:26
@FlorianPfaff
FlorianPfaff enabled auto-merge (squash) July 26, 2026 12:27
@FlorianPfaff
FlorianPfaff merged commit 33f0979 into main Jul 26, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant