Skip to content

Handle zero-sized circular sample requests#4767

Merged
FlorianPfaff merged 2 commits into
mainfrom
fix/circular-uniform-zero-samples
Jul 26, 2026
Merged

Handle zero-sized circular sample requests#4767
FlorianPfaff merged 2 commits into
mainfrom
fix/circular-uniform-zero-samples

Conversation

@FlorianPfaff

Copy link
Copy Markdown
Owner

Summary

  • return a backend-native empty (0, 1) array when CircularUniformSampler.sample_stochastic(0) is requested
  • avoid forwarding zero to CircularUniformDistribution.sample, whose contract requires a positive count
  • add a regression test for the sampler-level nonnegative-count contract

Validation

  • reviewed the branch diff against current main
  • added test_sample_stochastic_zero_samples_returns_empty_matrix
  • local repository tests could not be executed because this environment has no GitHub CLI and cannot clone GitHub; GitHub Actions can validate the branch

@github-actions

Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 25.19s
✅ JSON prettier 7 0 0 0 1.56s
✅ JSON v8r 7 0 0 3.91s
✅ MARKDOWN markdownlint 68 0 0 0 1.9s
✅ MARKDOWN markdown-table-formatter 68 0 0 0 0.73s
✅ PYTHON black 1702 257 0 0 104.05s
✅ PYTHON isort 1702 482 0 0 2.95s
✅ REPOSITORY betterleaks yes no no 2.46s
✅ REPOSITORY checkov yes no no 54.05s
✅ REPOSITORY gitleaks yes no no 16.2s
✅ REPOSITORY git_diff yes no no 0.56s
✅ REPOSITORY secretlint yes no no 77.73s
✅ REPOSITORY syft yes no no 6.54s
✅ REPOSITORY trivy-sbom yes no no 7.35s
✅ REPOSITORY trufflehog yes no no 32.25s
✅ YAML prettier 11 0 0 0 0.79s
✅ YAML v8r 11 0 0 11.9s
✅ YAML yamllint 11 0 0 0.72s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.6.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_BETTERLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@FlorianPfaff
FlorianPfaff marked this pull request as ready for review July 26, 2026 12:27
@FlorianPfaff
FlorianPfaff enabled auto-merge (squash) July 26, 2026 12:27
@FlorianPfaff
FlorianPfaff merged commit e86941b into main Jul 26, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant