Skip to content

Reject full smoothing without terminal posterior#4774

Merged
FlorianPfaff merged 2 commits into
mainfrom
agent/validate-full-smoothing-terminal-posterior
Jul 26, 2026
Merged

Reject full smoothing without terminal posterior#4774
FlorianPfaff merged 2 commits into
mainfrom
agent/validate-full-smoothing-terminal-posterior

Conversation

@FlorianPfaff

Copy link
Copy Markdown
Owner

Bug

EvidenceComputationMode accepted mode="full_smoothing" together with terminal_posterior=False.

That state is internally contradictory: full fixed-interval smoothing necessarily includes the terminal smoothed posterior. Allowing it produces diagnostics and downstream control flow that claim full smoothing while declaring that its terminal posterior is absent.

Fix

  • reject full_smoothing modes that disable terminal_posterior;
  • preserve the valid evidence-only case where callers explicitly do not request a terminal posterior.

Regression coverage

Added focused tests for both the rejected full-smoothing combination and the permitted evidence-only combination.

Scope

The branch is 2 commits ahead of current main, 0 behind, and changes only src/pyrecest/evidence.py plus one regression test module.

@FlorianPfaff
FlorianPfaff enabled auto-merge (squash) July 26, 2026 14:18
@github-actions

Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 25.3s
✅ JSON prettier 7 0 0 0 0.85s
✅ JSON v8r 7 0 0 5.31s
✅ MARKDOWN markdownlint 68 0 0 0 2.08s
✅ MARKDOWN markdown-table-formatter 68 0 0 0 1.05s
✅ PYTHON black 1706 257 0 0 109.18s
✅ PYTHON isort 1706 485 0 0 2.98s
✅ REPOSITORY betterleaks yes no no 2.54s
✅ REPOSITORY checkov yes no no 56.41s
✅ REPOSITORY gitleaks yes no no 16.51s
✅ REPOSITORY git_diff yes no no 0.36s
✅ REPOSITORY secretlint yes no no 85.69s
✅ REPOSITORY syft yes no no 6.49s
✅ REPOSITORY trivy-sbom yes no no 7.46s
✅ REPOSITORY trufflehog yes no no 33.27s
✅ YAML prettier 11 0 0 0 0.79s
✅ YAML v8r 11 0 0 12.18s
✅ YAML yamllint 11 0 0 0.88s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.6.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_BETTERLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@FlorianPfaff
FlorianPfaff merged commit f72b5de into main Jul 26, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant