Skip to content

WS-ART-001-04C1: close durable lineage planning gap - #294

Merged
abiorh-claw merged 2 commits into
mainfrom
codex/ws-art-001-04c1-durable-put-intent
Aug 7, 2026
Merged

WS-ART-001-04C1: close durable lineage planning gap#294
abiorh-claw merged 2 commits into
mainfrom
codex/ws-art-001-04c1-durable-put-intent

Conversation

@Abiorh001

@Abiorh001 Abiorh001 commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

WS-ART-001-04C1 Planning Correction PR Trust Bundle

Chunk

WS-ART-001-04C1 planning correction only.

Goal And Human Intent

Make the next ART durable-put chunk implementable without losing the guarantee
that the checked ZIP, durable storage intent, later verified admission, and
eventual Submission all refer to the same exact lineage.

What Changed And Why

Preimplementation review proved the generic ArtifactPutAttempt row alone
could not reconstruct actor, assignment, predecessor, manifest, evidence, and
locked-policy lineage for 04C2 after process loss. The corrected contract adds
one narrow SubmissionBundleDurableIntent joining the immutable passing
evidence set to the generic put attempt before provider I/O.

The correction also fixes the pre-intent crash rule: old evidence never remints
process-local authority; recovery requires complete reupload and checker
execution with a new prepared generation and evidence identity.

Design Chosen

  • Unique foreign keys from the intent to PreSubmitEvidenceSet and
    ArtifactPutAttempt; no duplicate lineage blob or request-digest parsing.
  • Live PreparedArtifact plus single-use PreSubmitPassCapability remain
    required for the mutation.
  • Typed TASK/PROJECT locks and opaque AUTH PREP consumption commit with the
    intent, provisional capacity, authorization evidence, and put attempt.
  • Provider I/O occurs only after commit and reuses existing generic
    observation/recovery.
  • Production contributor preparation stays unavailable until XINT-05A.

Rejected alternatives were generic metadata, parsing the request digest,
persisting scratch/handles, reminting authority from evidence, and adding a
submission-specific recovery path.

Scope Control And Product Behavior

Changed only ART planning, status, chunk contracts, normative specification,
and review evidence. No runtime behavior changes. 04C1 still excludes ready
admission publication, Submission/binding, public routes, review/contribution,
retention/deletion, provider redesign, and AUTH availability.

Acceptance Proof And Checks

  • git diff --check: passed.
  • stale artifact contract scan: passed.
  • Markdown link scan across six changed files: passed.
  • Test delta: none; planning-only.
  • CI integrity: no workflow, command, coverage, or dependency change.

Internal architecture, security/auth, product/ops, QA, senior-engineering, and
docs plan reviews passed after all material findings were incorporated.
External CI and CodeRabbit remain pending after PR publication.

Remaining Risks And Follow-Up

Implementation must keep the intent row narrow, update shared put-attempt
constraints safely, prove guide continuation ignores submission attempts, and
demonstrate provider I/O cannot occur before the durable transaction commits.
After this planning PR merges, implement 04C1; 04C2 remains separate.

Human Review Focus And Merge Ownership

Confirm the durable intent is necessary and sufficiently narrow, and that the
crash/replay wording never permits durable evidence to become mutation
authority. Human approval owns merge; the agent will not merge this PR.

Summary by CodeRabbit

  • Reliability

    • Submission artifacts now retain durable, evidence-linked lineage before storage begins.
    • Recovery can resume from persisted submission intent instead of relying on temporary process state.
    • Interrupted preparations before persistence require a fresh upload and validation, preventing stale authorization reuse.
    • Concurrent submissions are fenced to prevent generation reuse while still allowing identical content to be deduplicated.
  • Documentation

    • Updated artifact-storage specifications, acceptance criteria, status records, and review evidence to reflect the new durable submission and recovery behavior.

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@Abiorh001, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 12 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: c4e36de7-fff1-4a9e-985d-a343e3e1fcf8

📥 Commits

Reviewing files that changed from the base of the PR and between 809f5a1 and 2759e4d.

📒 Files selected for processing (4)
  • .agent-loop/initiatives/WS-ART-001-immutable-artifact-storage/PLAN.md
  • .agent-loop/initiatives/WS-ART-001-immutable-artifact-storage/chunks/WS-ART-001-04C1-durable-put-intent.md
  • .agent-loop/initiatives/WS-ART-001-immutable-artifact-storage/reviews/WS-ART-001-04C1-planning-correction-external-review-response.md
  • .agent-loop/initiatives/WS-ART-001-immutable-artifact-storage/reviews/WS-ART-001-04C1-planning-correction-pr-trust-bundle.md
📝 Walkthrough

Walkthrough

The change corrects the artifact-storage plan to persist evidence-linked submission intent before provider I/O. It defines immutable lineage, capability checks, atomic effects, recovery rules, concurrency fences, and downstream verification publication requirements.

Changes

Durable submission intent

Layer / File(s) Summary
Submission intent contract and recovery rules
.agent-loop/initiatives/WS-ART-001-immutable-artifact-storage/PLAN.md, .agent-loop/initiatives/WS-ART-001-immutable-artifact-storage/chunks/WS-ART-001-04C1-durable-put-intent.md, .agent-loop/initiatives/WS-ART-001-immutable-artifact-storage/reviews/*, docs/spec_artifact_storage_service.md
Defines SubmissionBundleDurableIntent, its evidence and put-attempt lineage, atomic pre-provider persistence, capability validation, uniqueness fences, and fresh-preparation recovery.
Publication integration and initiative state
.agent-loop/initiatives/WS-ART-001-immutable-artifact-storage/chunks/WS-ART-001-04C2-ready-admission-publication.md, .agent-loop/initiatives/WS-ART-001-immutable-artifact-storage/CHUNK_MAP.md, .agent-loop/initiatives/WS-ART-001-immutable-artifact-storage/STATUS.md
Adds durable-intent reload and verification publication requirements. Updates the 04C1 planning status and initiative records after authorization activation.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: abiorh-claw

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely identifies the durable lineage planning gap being addressed.
Description check ✅ Passed The description explains the goal, design, scope, evidence, risks, follow-up work, and human review focus for this planning-only PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/ws-art-001-04c1-durable-put-intent

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@abiorh-claw
abiorh-claw self-requested a review August 7, 2026 02:32
@abiorh-claw
abiorh-claw merged commit c5a9862 into main Aug 7, 2026
9 checks passed
@abiorh-claw
abiorh-claw deleted the codex/ws-art-001-04c1-durable-put-intent branch August 7, 2026 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants