WS-ART-001-04C1: close durable lineage planning gap - #294
Conversation
|
Warning Review limit reached
Next review available in: 12 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe change corrects the artifact-storage plan to persist evidence-linked submission intent before provider I/O. It defines immutable lineage, capability checks, atomic effects, recovery rules, concurrency fences, and downstream verification publication requirements. ChangesDurable submission intent
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
WS-ART-001-04C1 Planning Correction PR Trust Bundle
Chunk
WS-ART-001-04C1planning correction only.Goal And Human Intent
Make the next ART durable-put chunk implementable without losing the guarantee
that the checked ZIP, durable storage intent, later verified admission, and
eventual Submission all refer to the same exact lineage.
What Changed And Why
Preimplementation review proved the generic
ArtifactPutAttemptrow alonecould not reconstruct actor, assignment, predecessor, manifest, evidence, and
locked-policy lineage for 04C2 after process loss. The corrected contract adds
one narrow
SubmissionBundleDurableIntentjoining the immutable passingevidence set to the generic put attempt before provider I/O.
The correction also fixes the pre-intent crash rule: old evidence never remints
process-local authority; recovery requires complete reupload and checker
execution with a new prepared generation and evidence identity.
Design Chosen
PreSubmitEvidenceSetandArtifactPutAttempt; no duplicate lineage blob or request-digest parsing.PreparedArtifactplus single-usePreSubmitPassCapabilityremainrequired for the mutation.
intent, provisional capacity, authorization evidence, and put attempt.
observation/recovery.
Rejected alternatives were generic metadata, parsing the request digest,
persisting scratch/handles, reminting authority from evidence, and adding a
submission-specific recovery path.
Scope Control And Product Behavior
Changed only ART planning, status, chunk contracts, normative specification,
and review evidence. No runtime behavior changes. 04C1 still excludes ready
admission publication, Submission/binding, public routes, review/contribution,
retention/deletion, provider redesign, and AUTH availability.
Acceptance Proof And Checks
git diff --check: passed.Internal architecture, security/auth, product/ops, QA, senior-engineering, and
docs plan reviews passed after all material findings were incorporated.
External CI and CodeRabbit remain pending after PR publication.
Remaining Risks And Follow-Up
Implementation must keep the intent row narrow, update shared put-attempt
constraints safely, prove guide continuation ignores submission attempts, and
demonstrate provider I/O cannot occur before the durable transaction commits.
After this planning PR merges, implement 04C1; 04C2 remains separate.
Human Review Focus And Merge Ownership
Confirm the durable intent is necessary and sufficiently narrow, and that the
crash/replay wording never permits durable evidence to become mutation
authority. Human approval owns merge; the agent will not merge this PR.
Summary by CodeRabbit
Reliability
Documentation