AUTH-12F3: activate fixed-service policy derivation - #295
Conversation
|
Warning Review limit reached
Next review available in: 10 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (24)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PR Trust Bundle: WS-AUTH-001-12F3
Chunk
WS-AUTH-001-12F3— Fixed-Service Policy Derivation (L1).Goal
Activate submission-policy derivation only for
workstream.project.setup, runit through fresh fixed-service PREP in Celery, and remove public inline agent
derivation.
Human-approved intent
Complete AUTH-12F3 end to end without weakening authorization, tests, or CI;
use GitHub Actions for the full suite and coverage proof.
What changed
project.submission_artifact_policy.derivefor the fixedproject-setup service.
total lock ordering, atomic decision/product evidence, and exact replay.
reserved -> pending -> committedexecution-claim statemachine so process loss cannot repeat material or agent I/O.
without rerunning sufficiency.
guidance.
Why it changed
Automatic setup derivation needed a closed fixed-service boundary, exact
transactional evidence, and crash-safe replay before it could be activated.
Design chosen
Reuse the opaque
PreparedAuthorizationHandleprotocol and fixed-servicecomposition. Commit only a deterministic
reservedexecution claim beforeexternal I/O; after I/O, reload and lock the complete lineage, consume fresh
transaction-bound authority, then atomically bind and complete replay with the
policy and setup output.
Alternatives rejected
Scope control
No approval/effective/pre-submit mutation, post-submit policy activation, ART
behavior, generic service authority, frontend work, or CI changes are included.
Product behavior
An authoritative same-generation sufficiency result permits only the fixed
setup service to derive one immutable draft. Exact committed redelivery returns
that draft without external I/O. A failed post-reservation execution remains
durably fenced. Project Managers may create manual drafts but cannot invoke the
derivation agent inline.
Acceptance criteria proof
reservation, and zero-I/O redelivery: PostgreSQL integration test.
Tests/checks run
git diff --checkpassed.Test delta
Added fixed-service PREP, worker composition, stale custody, exact completed
replay, real PostgreSQL success/replay/crash recovery, route removal, catalogue
activation, migration-head, provenance, immutable-manual-update, and default
policy-floor assertions. No tests were skipped or weakened.
CI integrity
No workflow, lane, lint, coverage, or package-script changes. Repository-wide
78% and changed-subsystem 90% requirements remain intact.
Reviewer results
Architecture, security, QA, senior engineering, product/ops, test-delta, reuse,
docs, and CI-integrity reviews passed after findings were fixed.
External review
Pending CodeRabbit and exact-head GitHub Actions checks.
Remaining risks
Low: execution-fence and worker composition scaffolding parallels sufficiency;
extract a shared helper only if a third boundary establishes a stable pattern.
Follow-up work
After human merge, reassess and start
WS-AUTH-001-12F4as its own boundedchunk. Do not start it automatically from this PR.
Human review focus
Review migration 0059's one-way guards, the pre-I/O commit boundary, final
atomic PREP/evidence transaction, exact completed replay, and fixed-service-only
catalogue activation.
Human merge ownership
Only the user may authorize merge of the specific PR.