-
Notifications
You must be signed in to change notification settings - Fork 7
WS-POL-003-02: add unified project guide agent adapter #301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
7 changes: 4 additions & 3 deletions
7
.agent-loop/initiatives/WS-POL-003-unified-project-guide-compilation/CHUNK_MAP.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39 changes: 39 additions & 0 deletions
39
...ied-project-guide-compilation/reviews/WS-POL-003-02-internal-review-evidence.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| # WS-POL-003-02 Internal Review Evidence | ||
|
|
||
| Date: 2026-08-08. Risk: L1. | ||
|
|
||
| ## Deterministic evidence | ||
|
|
||
| - Scoped Ruff: passed. | ||
| - Focused compilation, adapter, and adjacent legacy regressions: 79 passed. | ||
| - Changed adapter coverage: 91.89 percent, above the 90 percent requirement. | ||
| - Real installed OpenAI Agents SDK accepted the strict result schema and the | ||
| tracing-disabled `RunConfig` fields. | ||
| - Repository docstring coverage: 80.5 percent, above the 80 percent gate. | ||
| - Stale wording, Markdown links, diff integrity, lane ownership, and strict | ||
| allowed-file scope checks: passed. | ||
| - No workflow, dependency, lockfile, package script, coverage threshold, skip, | ||
| xfail, database, authorization, Celery, registry, checker, or production | ||
| caller change exists. | ||
|
|
||
| ## Review results | ||
|
|
||
| - Architecture: pass; one existing port/adapter method, contract-owned | ||
| canonical serialization, no production rewiring or competing abstraction. | ||
| - Security: pass after strict provider schema, explicit tool-free construction, | ||
| provider tracing disablement, sensitive trace exclusion, and fail-closed | ||
| context-bound validation were proved. | ||
| - QA: pass after adding a dedicated unified envelope cap and preventing | ||
| double-encoding of large escapable canonical guide material. | ||
| - Product/operations: pass; the result remains an untrusted proposal and makes | ||
| no approval, activation, review, payment, contribution, or reputation | ||
| decision. | ||
| - Senior engineering: pass after canonical prompt serialization aligned every | ||
| accepted sub-12-MiB guide with the bounded unified envelope. | ||
| - Test delta: pass; tests are additive with no removed, skipped, or weakened | ||
| assertions. | ||
| - CI integrity: pass; commands and lane ownership are correct and no gate was | ||
| weakened. | ||
|
|
||
| All High findings were corrected and re-reviewed. No reviewer session remains | ||
| open. |
53 changes: 53 additions & 0 deletions
53
...-003-unified-project-guide-compilation/reviews/WS-POL-003-02-pr-trust-bundle.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| # WS-POL-003-02 PR Trust Bundle | ||
|
|
||
| ## Goal and design | ||
|
|
||
| Add one hidden `compile_project_guide` runtime method that sends the merged | ||
| strict context through exactly one provider call and validates the complete | ||
| untrusted result before returning. The existing adapter/helper is reused; no | ||
| second runtime, registry, compiler, or production path is introduced. | ||
|
|
||
| The unified call uses provider-level strict JSON schema, no tools/handoffs/MCP | ||
| or search capability, a tracing-disabled sensitive-data-excluding per-run | ||
| configuration, a 16 MiB complete-envelope cap, deterministic canonical prompt | ||
| serialization without double-encoding guide JSON, timeout/cancellation, and | ||
| sanitized failures. | ||
|
|
||
| ## Scope | ||
|
|
||
| Changed runtime files are limited to the project-agent protocol, OpenAI adapter, | ||
| and focused fake-runtime tests. Initiative status, contract, and review evidence | ||
| are updated with them. No database, migration, AUTH, Celery, API, service | ||
| orchestration, policy persistence/approval, catalogue, checker runtime, | ||
| dependency, composition root, production caller, or live-cutover change exists. | ||
|
|
||
| ## Acceptance proof | ||
|
|
||
| - Exactly one `Runner.run` call and one strict `ProjectGuideCompilationResult` | ||
| schema wrapper are asserted. | ||
| - Canonical prompt input remains untrusted and is separated from instructions. | ||
| - No tool/network/file/handoff/MCP/search configuration is supplied. | ||
| - Provider tracing and sensitive trace data are explicitly disabled. | ||
| - Trusted semantic validation rejects shaped but invalid results before return. | ||
| - A valid near-bound quote-heavy guide that previously expanded above 16 MiB | ||
| now serializes once below the bound; oversized envelopes deny before SDK I/O. | ||
| - Timeout is sanitized and caller cancellation propagates. | ||
| - Legacy runtime behavior and production call sites remain unchanged. | ||
|
|
||
| ## Evidence and reviews | ||
|
|
||
| - Ruff passed. | ||
| - 79 focused/adjacent tests passed. | ||
| - Changed adapter coverage: 91.89 percent. | ||
| - Docstring coverage: 80.5 percent. | ||
| - Architecture, security, QA, product/operations, senior engineering, test | ||
| delta, and CI integrity reviews passed after fixes. | ||
| - Stale wording, Markdown links, scope, lane ownership, and diff checks passed. | ||
|
|
||
| ## Remaining risk and human focus | ||
|
|
||
| This method is deliberately hidden and unused. Later persistence/orchestration | ||
| chunks must preserve one logical attempt and must not enable provider tracing, | ||
| tools, or a second inference path. Human review should focus on canonical prompt | ||
| fidelity, the no-trace/no-tools boundary, result validation, cancellation/error | ||
| semantics, and absence of production rewiring. |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.