Repository navigation
fix(player): play the chosen audio on the HLS fallback - #422
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hls-audio-trackis added to the player log.Related issue
No issue of its own. Found while auditing #339, #342 and #343.
Change type
Validation
pnpm test: 214 files, 1263 tests passedpnpm build: passedcargo fmt --manifest-path src-tauri/Cargo.toml --all -- --check: passedcargo clippy --manifest-path src-tauri/Cargo.toml --all-targets --all-features: exit 0cargo test --manifest-path src-tauri/Cargo.toml --all-targets --all-features: 63 suites, 1210 passed, 0 failedAgent checks in
pnpm tauri devon macOS, isolated profile, hidden window, with HLS temporarily forced as the first source, one run each. Audio is the track hls.js reported, not listened to:lGalJmyI78w(21 languages)tHG9pCh7HjI(19 languages)dQw4w9WgXcQ(no dubs)In both dubbed manifests no track has
DEFAULT=YES, which is why hls.js took the first one.Screenshots or recordings
Risk and compatibility
Playback: only the hls.js path changes. A live stream with no named audio tracks keeps its current behavior, but no live stream was run.
Only macOS was run. Windows and Linux use the same hls.js code.
No migrations, database changes, permissions, Rust changes, network changes or background work.
No new secrets, private data, telemetry, or broad Tauri permissions were introduced.
User-facing documentation was updated where needed.
Dependency and lockfile changes are intentional and limited to this PR.
Breaking changes and upgrade steps are clearly documented.