Skip to content

fix(music): stop music shelves from snapping past their first card - #654

Merged
A-EDev merged 1 commit into
mainfrom
fix/music-shelf-snap-offset
Nov 16, 2026
Merged

A-EDev merged 1 commit into
mainfrom
fix/music-shelf-snap-offset

Conversation

@A-EDev

@A-EDev A-EDev commented Nov 16, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Music shelves (Music shelf, Quick picks, Speed dial, Moods) snap their items to the start, but the scroller has 12px of side padding with no matching scroll padding. The browser snapped the first card flush to the scroller's edge on load, so a shelf started 12px scrolled: the back arrow showed on hover and the first card's hover background was clipped.
  • Adds scroll-px-3 next to px-3 on every snapping shelf (also Library and video shelves, which use the same padding) so the snap point is the padded start.
  • Changelog line under MUSIC.

Related issue

Change type

  • Bug fix
  • Feature
  • Refactor or maintenance
  • Documentation
  • Build, packaging, or CI

Validation

Run on a branch that merges this PR with the other two UI PRs from the same batch (frontend only, no Rust changes):

  • pnpm test: 456 files, 2706 tests, 0 failures
  • pnpm build: tsc and vite build pass
  • cargo fmt --manifest-path src-tauri/Cargo.toml --all -- --check
  • cargo clippy --manifest-path src-tauri/Cargo.toml --all-targets --all-features
  • cargo test --manifest-path src-tauri/Cargo.toml --all-targets --all-features
  • I smoke-tested the affected desktop behavior.

OS: macOS dev build only. On the Music page, all eight shelves measured report scrollLeft 0 after load, and the first card lines up with the mood chips.

Screenshots or recordings

Risk and compatibility

Frontend layout only. No migrations, database, network, permission or background work changes.

  • No new secrets, private data, telemetry, or broad Tauri permissions were introduced.
  • User-facing documentation was updated where needed.
  • Dependency and lockfile changes are intentional and limited to this PR.
  • Breaking changes and upgrade steps are clearly documented.

@A-EDev
A-EDev merged commit c61e69e into main Nov 16, 2026
11 checks passed
@A-EDev
A-EDev deleted the fix/music-shelf-snap-offset branch November 16, 2026 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant